From: Sam Ravnborg <sam@ravnborg.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: devicetree@vger.kernel.org, yamonkar@cadence.com,
praneeth@ti.com, dri-devel@lists.freedesktop.org,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
laurent.pinchart@ideasonboard.com, sjakhade@cadence.com,
maxime@cerno.tech
Subject: Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Wed, 15 Jan 2020 18:13:58 +0100 [thread overview]
Message-ID: <20200115171358.GA23015@ravnborg.org> (raw)
In-Reply-To: <b4f5d846-aa44-a759-1caa-70244dfabeb3@ti.com>
Hi Jyri.
> Well, I'll bite the bullet then, and start mangling the code to the
> "strict" format.
While touching the code please consider moving all logging
over to the new drm_{err,warn,info,dbg} functions.
They give the nice "[drm]" marker.
And they are a tad shorter as you do not have to dereference ddev->dev
everywhere.
And you then also gain support for controlling logging using
drm.debug=0xxxx, os sysfs too.
See drm_print.h in latest drm_misc_next
With or without this change you can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-15 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:45 [PATCH v6 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 1/5] dt-bindings: display: ti, k2g-dss: Add dt-schema yaml binding Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 12:22 ` Sam Ravnborg
2020-01-15 14:27 ` Jyri Sarha
2020-01-15 14:43 ` Sam Ravnborg
2020-01-15 14:58 ` Jyri Sarha
2020-01-15 17:13 ` Sam Ravnborg [this message]
2020-01-16 13:16 ` Jyri Sarha
2020-01-15 12:29 ` Sam Ravnborg
2020-01-15 11:45 ` [PATCH v6 5/5] MAINTAINERS: add entry for tidss Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115171358.GA23015@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=maxime@cerno.tech \
--cc=peter.ujfalusi@ti.com \
--cc=praneeth@ti.com \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).