From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29622C32771 for ; Wed, 15 Jan 2020 21:01:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03B81207FF for ; Wed, 15 Jan 2020 21:01:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03B81207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68CD16EA94; Wed, 15 Jan 2020 21:01:14 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A50AA6EA94 for ; Wed, 15 Jan 2020 21:01:12 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 684A8804C3; Wed, 15 Jan 2020 22:01:06 +0100 (CET) Date: Wed, 15 Jan 2020 22:01:04 +0100 From: Sam Ravnborg To: Geert Uytterhoeven Subject: Re: [PATCH v2 1/5] dt-bindings: display: sitronix,st7735r: Convert to DT schema Message-ID: <20200115210104.GA28904@ravnborg.org> References: <20200115124548.3951-1-geert+renesas@glider.be> <20200115124548.3951-2-geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200115124548.3951-2-geert+renesas@glider.be> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=gEfo2CItAAAA:8 a=WZHNqt2aAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=o07Ec-Mc6pqL289OE5cA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=sptkURWiP4Gy88Gu7hUp:22 a=PrHl9onO2p7xFKlKy1af:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Lechner , David Airlie , Kieran Bingham , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Chris Brandt , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Geert. Thanks for doing the conversion to meta-schema. On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote: > Convert the DT binding documentation for Sitronix ST7735R displays to DT > schema. > > Add a reference to the Adafruit 1.8" LCD while at it. > > Signed-off-by: Geert Uytterhoeven > --- > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > new file mode 100644 > index 0000000000000000..21bccc91f74255e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only Use (GPL-2.0-only OR BSD-2-Clause) for new binding files. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sitronix ST7735R Display Panels Device Tree Bindings > + > +maintainers: > + - David Lechner > + > +description: > + This binding is for display panels using a Sitronix ST7735R controller in > + SPI mode. > + > +allOf: > + - $ref: panel/panel-common.yaml# I am no binding expert so I do not know how to add it. But the old binding described that this MUST be a child of spi. This is missing here. Other panels using spi does not have it - so it is probarly OK. So with the license fixed: Reviewed-by: Sam Ravnborg > + > +properties: > + compatible: > + oneOf: > + - description: > + Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618) > + items: > + - enum: > + - jianda,jd-t18003-t01 > + - const: sitronix,st7735r > + > + spi-max-frequency: > + maximum: 32000000 > + > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) > + > +required: > + - compatible > + - reg > + - dc-gpios > + - reset-gpios > + > +examples: > + - | > + #include > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>; > + }; > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0{ > + compatible = "jianda,jd-t18003-t01", "sitronix,st7735r"; > + reg = <0>; > + spi-max-frequency = <32000000>; > + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>; > + rotation = <270>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index ea8262509bdd21ac..3007f83bd504194a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5382,7 +5382,7 @@ M: David Lechner > T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/tiny/st7735r.c > -F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt > +F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > > DRM DRIVER FOR SONY ACX424AKP PANELS > M: Linus Walleij > -- > 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel