Hi Stephan,

On Mon, Jan 13, 2020 at 05:30:39PM +0100, Stephan Gerhold wrote:
> On Mon, Dec 16, 2019 at 07:08:12PM +0100, Stephan Gerhold wrote:
> > On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote:
> > > On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote:
> > > > At the moment, video mode parameters like video=540x960,reflect_x,
> > > > (without rotation set) are not taken into account when applying the
> > > > mode in drm_client_modeset.c.
> > >
> > > A rotation value without exactly one rotation angle is illegal.
> > > IMO the code should not generate a value like that in the first
> > > place.
> > >
>
> What do you think about Ville's comment?
> Should we change the command line parser to generate ROTATE_0 when no
> rotate option is specified? This would also require updating a few of
> the test cases.

I agree with him :)

Maxime