From: Sam Ravnborg <sam@ravnborg.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
stonea168@163.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com
Subject: Re: [PATCH v9 1/5] dt-bindings: display: panel: Add boe tv101wum-n16 panel bindings
Date: Fri, 17 Jan 2020 19:08:17 +0100 [thread overview]
Message-ID: <20200117180817.GA17294@ravnborg.org> (raw)
In-Reply-To: <20200116021511.22675-2-jitao.shi@mediatek.com>
Hi Jitao.
Looks good, much better than the individual files.
Rob Herring is still listed as maintainer which I questioned in last
feedback.
With this resolved (kept only if Rob confirms), this is
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
On Thu, Jan 16, 2020 at 10:15:07AM +0800, Jitao Shi wrote:
> Add documentation for "boe,tv101wum-n16", "auo,kd101n80-45na",
> "boe,tv101wum-n53" and "auo,b101uan08.3" panels.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> .../display/panel/boe,tv101wum-nl6.yaml | 81 +++++++++++++++++++
> 1 file changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> new file mode 100644
> index 000000000000..cc4e058f5eee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/boe,tv101wum-nl6.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BOE TV101WUM-NL6 DSI Display Panel
> +
> +maintainers:
> + - Thierry Reding <thierry.reding@gmail.com>
> + - Sam Ravnborg <sam@ravnborg.org>
> + - Rob Herring <robh+dt@kernel.org>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + # BOE TV101WUM-NL6 10.1" WUXGA TFT LCD panel
> + - boe,tv101wum-nl6
> + # AUO KD101N80-45NA 10.1" WUXGA TFT LCD panel
> + - auo,kd101n80-45na
> + # BOE TV101WUM-N53 10.1" WUXGA TFT LCD panel
> + - boe,tv101wum-n53
> + # AUO B101UAN08.3 10.1" WUXGA TFT LCD panel
> + - auo,b101uan08.3
> +
> + reg:
> + description: the virtual channel number of a DSI peripheral
> +
> + enable-gpios:
> + description: a GPIO spec for the enable pin
> +
> + pp1800-supply:
> + description: core voltage supply
> +
> + avdd-supply:
> + description: phandle of the regulator that provides positive voltage
> +
> + avee-supply:
> + description: phandle of the regulator that provides negative voltage
> +
> + backlight:
> + description: phandle of the backlight device attached to the panel
> +
> + port: true
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - pp1800-supply
> + - avdd-supply
> + - avee-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "boe,tv101wum-nl6";
> + reg = <0>;
> + enable-gpios = <&pio 45 0>;
> + avdd-supply = <&ppvarn_lcd>;
> + avee-supply = <&ppvarp_lcd>;
> + pp1800-supply = <&pp1800_lcd>;
> + backlight = <&backlight_lcd0>;
> + status = "okay";
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.21.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-17 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 2:15 [PATCH v9 0/5] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels Jitao Shi
2020-01-16 2:15 ` [PATCH v9 1/5] dt-bindings: display: panel: Add boe tv101wum-n16 panel bindings Jitao Shi
2020-01-17 18:08 ` Sam Ravnborg [this message]
2020-01-17 18:30 ` Sam Ravnborg
2020-01-16 2:15 ` [PATCH v9 2/5] drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel Jitao Shi
2020-01-16 2:15 ` [PATCH v9 3/5] drm/panel: support for auo, kd101n80-45na " Jitao Shi
2020-01-16 2:15 ` [PATCH v9 4/5] drm/panel: support for boe, tv101wum-n53 " Jitao Shi
2020-01-16 2:15 ` [PATCH v9 5/5] drm/panel: support for auo, b101uan08.3 " Jitao Shi
2020-01-17 18:31 ` [PATCH v9 0/5] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117180817.GA17294@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=cawa.cheng@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=thierry.reding@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).