From: Thierry Reding <thierry.reding@gmail.com>
To: allen <allen.chen@ite.com.tw>
Cc: Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
"open list:DRM DRIVERS FOR NVIDIA TEGRA"
<linux-tegra@vger.kernel.org>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v6 2/4] Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM"
Date: Mon, 20 Jan 2020 08:09:43 +0100 [thread overview]
Message-ID: <20200120070943.GA197819@ulmo> (raw)
In-Reply-To: <1579488364-13182-3-git-send-email-allen.chen@ite.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 2055 bytes --]
On Mon, Jan 20, 2020 at 10:44:32AM +0800, allen wrote:
> IT6505 driver ite-it6505.c file using drm_dp_link helpers, so revert.
> This reverts commit 9a42c7c647a9ad0f7ebb147a52eda3dcb7c84292.
>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 128 ++++++
> drivers/gpu/drm/tegra/Makefile | 1 -
> drivers/gpu/drm/tegra/dp.c | 876 ----------------------------------------
> drivers/gpu/drm/tegra/dp.h | 177 --------
> drivers/gpu/drm/tegra/dpaux.c | 1 -
> drivers/gpu/drm/tegra/sor.c | 1 -
> include/drm/drm_dp_helper.h | 16 +
> 7 files changed, 144 insertions(+), 1056 deletions(-)
> delete mode 100644 drivers/gpu/drm/tegra/dp.c
> delete mode 100644 drivers/gpu/drm/tegra/dp.h
Sorry, but no. Please just duplicate whatever information you need from
these helpers into your driver. The decision was made recently to remove
these helpers because they were a premature generalization and unlikely
to be useful very widely. See this commit:
commit 9a42c7c647a9ad0f7ebb147a52eda3dcb7c84292
Author: Thierry Reding <treding@nvidia.com>
Date: Mon Oct 21 16:34:37 2019 +0200
drm/tegra: Move drm_dp_link helpers to Tegra DRM
During the discussion of patches that enhance the drm_dp_link helpers it
was concluded that these helpers aren't very useful to begin with. After
all other drivers have been converted not to use these helpers anymore,
move these helpers into the last remaining user: Tegra DRM.
If at some point these helpers are deemed more widely useful, they can
be moved out into the DRM DP helpers again.
Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20191021143437.1477719-14-thierry.reding@gmail.com
Your new driver here doesn't change that, in my opinion, so just follow
what we did for other drivers and duplicate the corresponding code into
the driver.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-20 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 2:44 [PATCH v6 0/4] IT6505 cover letter allen
2020-01-20 2:44 ` [PATCH v6 2/4] Revert "drm/tegra: Move drm_dp_link helpers to Tegra DRM" allen
2020-01-20 7:09 ` Thierry Reding [this message]
2020-01-20 2:44 ` [PATCH v6 3/4] dt-bindings: Add binding for IT6505 allen
2020-01-21 18:00 ` Rob Herring
2020-01-20 2:44 ` [PATCH v6 4/4] drm/bridge: add it6505 driver allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120070943.GA197819@ulmo \
--to=thierry.reding@gmail.com \
--cc=Jau-Chih.Tseng@ite.com.tw \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pihsun@chromium.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).