From: Sam Ravnborg <sam@ravnborg.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm: fix parameters documentation style
Date: Mon, 20 Jan 2020 21:21:29 +0100 [thread overview]
Message-ID: <20200120202129.GB17555@ravnborg.org> (raw)
In-Reply-To: <372573cc-b0ae-72cb-f2c3-3f9310c3cf27@st.com>
Hi Benjamin.
On Mon, Jan 20, 2020 at 08:11:01AM +0000, Benjamin GAIGNARD wrote:
>
> On 1/18/20 10:41 AM, Sam Ravnborg wrote:
> > Hi Benjamin
> >
> > On Tue, Jan 14, 2020 at 05:01:35PM +0100, Benjamin Gaignard wrote:
> >> Remove old documentation style and use new one to avoid warnings when
> >> compiling with W=1
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > Thanks for the warning fixes.
> > This is legacy stuff that is not even wired into the kernel-doc stuff.
> > But that is no excuse for old-style comments.
>
> There is still quite a few of them in other drm files (drm_context.c,
> drm_bufs.c, drm_vm.c, drm_lock.c)
>
> but I don't know how to fix them. Your advices are welcome.
I have no strong opinion on way forward here.
But if someone (you?) type the patches and they are even acked,
we should not ignore them.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-01-20 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:01 [PATCH v2] drm: fix parameters documentation style Benjamin Gaignard
2020-01-14 16:04 ` Randy Dunlap
2020-01-18 9:41 ` Sam Ravnborg
2020-01-20 8:11 ` Benjamin GAIGNARD
2020-01-20 20:21 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120202129.GB17555@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).