* [PATCH] drm/virtio: fix error check
@ 2020-02-14 8:01 Gerd Hoffmann
2020-02-14 8:57 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2020-02-14 8:01 UTC (permalink / raw)
To: dri-devel
Cc: David Airlie, smitterl, cohuck, open list, gurchetansingh,
Gerd Hoffmann, open list:VIRTIO GPU DRIVER
The >= compare op must happen in cpu byte order, doing it in
little endian fails on big endian machines like s390.
Reported-by: Sebastian Mitterle <smitterl@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
index cfe9c54f87a3..67caecde623e 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -222,7 +222,7 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
trace_virtio_gpu_cmd_response(vgdev->ctrlq.vq, resp);
if (resp->type != cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA)) {
- if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
+ if (le32_to_cpu(resp->type) >= VIRTIO_GPU_RESP_ERR_UNSPEC) {
struct virtio_gpu_ctrl_hdr *cmd;
cmd = virtio_gpu_vbuf_ctrl_hdr(entry);
DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n",
--
2.18.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/virtio: fix error check
2020-02-14 8:01 [PATCH] drm/virtio: fix error check Gerd Hoffmann
@ 2020-02-14 8:57 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2020-02-14 8:57 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: David Airlie, smitterl, open list, dri-devel, gurchetansingh,
open list:VIRTIO GPU DRIVER
On Fri, 14 Feb 2020 09:01:00 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> The >= compare op must happen in cpu byte order, doing it in
> little endian fails on big endian machines like s390.
>
> Reported-by: Sebastian Mitterle <smitterl@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index cfe9c54f87a3..67caecde623e 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -222,7 +222,7 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
> trace_virtio_gpu_cmd_response(vgdev->ctrlq.vq, resp);
>
> if (resp->type != cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA)) {
> - if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
> + if (le32_to_cpu(resp->type) >= VIRTIO_GPU_RESP_ERR_UNSPEC) {
> struct virtio_gpu_ctrl_hdr *cmd;
> cmd = virtio_gpu_vbuf_ctrl_hdr(entry);
> DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n",
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Endianness continues to be fun.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-14 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 8:01 [PATCH] drm/virtio: fix error check Gerd Hoffmann
2020-02-14 8:57 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).