From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47EA3C35242 for ; Fri, 14 Feb 2020 21:54:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 172442168B for ; Fri, 14 Feb 2020 21:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bfTkxxCd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 172442168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FFB16FBAF; Fri, 14 Feb 2020 21:54:30 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B8E06FBAF; Fri, 14 Feb 2020 21:54:29 +0000 (UTC) Received: from localhost (unknown [65.119.211.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25E892187F; Fri, 14 Feb 2020 21:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581717269; bh=8Ebtq9A+AtuBJOntDicY0rR/lJZViC+UEAZu9rPpKl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bfTkxxCddELi/TRjJNFHtsLoMFRKSS2M5KOPK0vmRFNwlLhU3dVWR5NktoePPI9G7 mCzQaKFCMTzVTLG4oWgN7FjE3mXEmB8ddwhuQzoT2uWOoeTVopyUfEY6DuWmCkPhKC Hl5wVH0o+iSLC12EnoniR4le08s+RvzlN06NvtDs= Date: Fri, 14 Feb 2020 16:44:29 -0500 From: Greg KH To: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.5 155/542] drm/amdkfd: remove set but not used variable 'top_dev' Message-ID: <20200214214429.GA4193448@kroah.com> References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-155-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200214154854.6746-155-sashal@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Felix Kuehling , linux-kernel@vger.kernel.org, stable@vger.kernel.org, zhengbin , Hulk Robot , amd-gfx@lists.freedesktop.org, Alex Deucher Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 14, 2020 at 10:42:27AM -0500, Sasha Levin wrote: > From: zhengbin > > [ Upstream commit d191bd678153307573d615bb42da4fcca19fe477 ] > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init: > drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable] > > Reported-by: Hulk Robot > Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes") > Signed-off-by: zhengbin > Reviewed-by: Felix Kuehling > Signed-off-by: Felix Kuehling > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 --- > 1 file changed, 3 deletions(-) Unless all of these "unused bt set variable" patches are needed for "real" fixes, there's no need to add them here as we are NOT building the kernel with that option enabled any time soon from what I can tell. So you can drop a ton of these patches from all of these AUTOSEL branches please. thanks, greg kh _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel