From: Rob Herring <robh@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, drinkcat@chromium.org,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
hsinyi@chromium.org, matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH v2 1/2] Documentation: bindings: Add ANX7688 HDMI to DP bridge binding
Date: Wed, 19 Feb 2020 09:30:19 -0600 [thread overview]
Message-ID: <20200219153019.GA19271@bogus> (raw)
In-Reply-To: <20200213145416.890080-1-enric.balletbo@collabora.com>
On Thu, Feb 13, 2020 at 03:54:15PM +0100, Enric Balletbo i Serra wrote:
> From: Nicolas Boichat <drinkcat@chromium.org>
'dt-bindings: ....' for the subject please.
>
> Add documentation for DT properties supported by anx7688 HDMI-DP
> converter.
>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2:
> - Improve a bit the descriptions using the info from the datasheet.
> - Convert binding to yaml.
> - Use dual licensing.
>
> .../bindings/display/bridge/anx7688.yaml | 79 +++++++++++++++++++
Use the full compatible string: analogix,anx7688.yaml
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.yaml b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml
> new file mode 100644
> index 000000000000..c1b4b5191d44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/anx7688.yaml#
Don't forget to update this too.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analogix ANX7688 HDMI to USB Type-C Bridge (Port Controller with MUX)
> +
> +maintainers:
> + - Nicolas Boichat <drinkcat@chromium.org>
> + - Enric Balletbo i Serra <enric.balletbo@collabora.com>
> +
> +description: |
> + The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per
> + second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video
> + resolution from a smartphone or tablet with full function USB-C.
> +
> + This binding only describes the HDMI to DP display bridge.
> +
> +properties:
> + compatible:
> + const: analogix,anx7688
> +
> + reg:
> + maxItems: 1
> + description: I2C address of the device
That's every reg, you can drop 'description'.
> +
> + ports:
> + type: object
> +
> + properties:
> + port@0:
> + type: object
> + description: |
> + Video port for HDMI input
> +
> + port@1:
> + type: object
> + description: |
> + Video port for DP output
> +
> + required:
> + - port@0
IMO, port@1 should be required too. If not a fixed panel, then it should
have a connector node.
> +
> +required:
> + - compatible
> + - reg
> + - ports
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + anx7688: dp-bridge@2c {
> + compatible = "analogix,anx7688";
> + reg = <0x2c>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + anx7866_in: endpoint {
> + remote-endpoint = <&hdmi0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + anx7866_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> + };
> + };
> --
> 2.25.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-19 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:54 [PATCH v2 1/2] Documentation: bindings: Add ANX7688 HDMI to DP bridge binding Enric Balletbo i Serra
2020-02-13 14:54 ` [PATCH v2 2/2] drm/bridge: anx7688: Add anx7688 bridge driver support Enric Balletbo i Serra
2020-02-14 12:18 ` Andrzej Hajda
2020-02-14 13:29 ` Nicolas Boichat
2020-02-15 0:36 ` Nicolas Boichat
2020-02-14 21:36 ` Vasily Khoruzhick
2020-02-14 21:53 ` Enric Balletbo Serra
2020-02-14 22:17 ` Vasily Khoruzhick
2020-02-14 22:20 ` Enric Balletbo Serra
2020-02-14 22:22 ` Vasily Khoruzhick
2020-03-05 15:28 ` Enric Balletbo i Serra
2020-03-05 18:29 ` Vasily Khoruzhick
2020-03-05 18:35 ` Icenowy Zheng
2020-03-06 8:46 ` Enric Balletbo i Serra
2020-03-05 19:35 ` Ondřej Jirman
2020-03-06 8:46 ` Enric Balletbo i Serra
2020-03-06 8:53 ` Icenowy Zheng
2020-03-06 12:07 ` Ondřej Jirman
2020-03-06 12:11 ` Nicolas Boichat
2020-03-06 12:46 ` Ondřej Jirman
2020-03-06 12:03 ` Ondřej Jirman
2020-03-06 12:18 ` Enric Balletbo i Serra
2020-02-15 0:57 ` Nicolas Boichat
2020-02-19 15:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219153019.GA19271@bogus \
--to=robh@kernel.org \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).