From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC44C11D00 for ; Thu, 20 Feb 2020 08:45:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9882E207FD for ; Thu, 20 Feb 2020 08:45:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9882E207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08DA06ECF6; Thu, 20 Feb 2020 08:45:41 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id A575D6EC44 for ; Wed, 19 Feb 2020 16:19:39 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D5CCB80F3; Wed, 19 Feb 2020 16:20:19 +0000 (UTC) Date: Wed, 19 Feb 2020 08:19:32 -0800 From: Tony Lindgren To: Lee Jones Subject: Re: LED backlight on Droid 4 and others Message-ID: <20200219161932.GK35972@atomide.com> References: <20200105183202.GA17784@duo.ucw.cz> <20200106084549.GA14821@dell> <20200211172900.GH64767@atomide.com> <20200212201638.GB20085@amd> <20200218135219.GC3494@dell> <20200218141452.GF35972@atomide.com> <20200218231001.GA28817@amd> <20200219074730.GD3494@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219074730.GD3494@dell> X-Mailman-Approved-At: Thu, 20 Feb 2020 08:45:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, mpartap@gmx.net, jingoohan1@gmail.com, merlijn@wizzup.org, martin_rysavy@centrum.cz, kernel list , dri-devel@lists.freedesktop.org, sre@kernel.org, nekit1000@gmail.com, tomi.valkeinen@ti.com, Pavel Machek , jjhiblot@ti.com, linux-omap@vger.kernel.org, agx@sigxcpu.org, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Lee Jones [200219 07:47]: > On Wed, 19 Feb 2020, Pavel Machek wrote: > > > Hi! > > > > > > > > > > It would be good to get LED backlight to work in clean way for 5.6 > > > > > > > > kernel. > > > > > > ... > > > > > > > > [If you have an idea what else is needed, it would be welcome; it > > > > > > > > works for me in development tree but not in tree I'd like to > > > > > > > > upstream.] > > > > > > > > > > > > > > > > Lee, would you be willing to take "backlight: add led-backlight > > > > > > > > driver"? Would it help if I got "leds: Add managed API to get a LED > > > > > > > > from a device driver" and "leds: Add of_led_get() and led_put()" into > > > > > > > > for_next tree of the LED subsystem? > > > > > > > > > > > > > > It looks like you have an open question from Tony on v10. > > > > > > > > > > > > > > Is that patch orthogonal, or are there depend{ants,encies}? > > > > > > > > > > > > Uhh looks like we messed up a bit with integration. Now droid4 > > > > > > LCD backlight can no longer be enabled at all manually in v5.6-rc1 > > > > > > without the "add led-backlight driver" patch.. Should we just > > > > > > merge it to fix it rather than start scrambling with other > > > > > > temporary hacks? > > > > > > > > > > We should just merge the "add led-backlight driver". Everything should > > > > > be ready for it. I'm sorry if I broke something working, I was not > > > > > aware it worked at all. > > > > > > > > > > Unfortunately, this is backlight code, not LED, so I can't just merge it. > > > > > > > > Please go ahead. Apply my Acked-by and merge away ASAP. > > > > > > > > Acked-by: Lee Jones > > > > > > OK best to merge the driver via the LED tree: > > > > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > > Is the patch below the one both of you are talking about? > > > > Hmm. I should s/default-brightness-level/default-brightness/ > > below. > > > > Lee, I can of course take it (thanks), but won't Kconfig/Makefile > > pieces cause rejects? It might be still better if you took it. I can > > hand-edit it and submit it in form for easy application... tommorow. > > My suggestion would be to send it to Linus ASAP. > > Ideally it would get into the -rcs, as it 'fixes' things. I agree. Pavel, the version of the patch you posted is all space trashed. Can you please post again so I can verify the related dts changes against it? Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel