From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Marek Olšák" <marek.olsak@amd.com>,
"Tianci.Yin" <tianci.yin@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Evan Quan" <evan.quan@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xiaojie Yuan" <xiaojie.yuan@amd.com>
Subject: [PATCH 1/3] drm/amdgpu: Drop DRIVER_USE_AGP
Date: Sat, 22 Feb 2020 18:54:31 +0100 [thread overview]
Message-ID: <20200222175433.2259158-1-daniel.vetter@ffwll.ch> (raw)
This doesn't do anything except auto-init drm_agp support when you
call drm_get_pci_dev(). Which amdgpu stopped doing with
commit b58c11314a1706bf094c489ef5cb28f76478c704
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Fri Jun 2 17:16:31 2017 -0400
drm/amdgpu: drop deprecated drm_get_pci_dev and drm_put_dev
No idea whether this was intentional or accidental breakage, but I
guess anyone who manages to boot a this modern gpu behind an agp
bridge deserves a price. A price I never expect anyone to ever collect
:-)
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Xiaojie Yuan <xiaojie.yuan@amd.com>
Cc: Evan Quan <evan.quan@amd.com>
Cc: "Tianci.Yin" <tianci.yin@amd.com>
Cc: "Marek Olšák" <marek.olsak@amd.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 4598836c5fa4..6cea92017109 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1379,7 +1379,7 @@ int amdgpu_file_to_fpriv(struct file *filp, struct amdgpu_fpriv **fpriv)
static struct drm_driver kms_driver = {
.driver_features =
- DRIVER_USE_AGP | DRIVER_ATOMIC |
+ DRIVER_ATOMIC |
DRIVER_GEM |
DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ |
DRIVER_SYNCOBJ_TIMELINE,
--
2.24.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-02-22 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 17:54 Daniel Vetter [this message]
2020-02-22 17:54 ` [PATCH 2/3] drm/radeon: Inline drm_get_pci_dev Daniel Vetter
2020-02-24 16:31 ` Emil Velikov
2020-02-24 20:46 ` Daniel Vetter
2020-02-24 20:49 ` Daniel Vetter
2020-02-25 15:26 ` Alex Deucher
2020-02-22 17:54 ` [PATCH 3/3] drm/pci: Unexport drm_get_pci_dev Daniel Vetter
2020-02-24 16:33 ` Emil Velikov
2020-02-25 9:36 ` Thomas Zimmermann
2020-02-25 16:58 ` [PATCH] " Daniel Vetter
2020-03-06 15:08 ` Daniel Vetter
2020-02-24 15:30 ` [PATCH 1/3] drm/amdgpu: Drop DRIVER_USE_AGP Emil Velikov
2020-02-24 16:10 ` Alex Deucher
2020-02-24 20:43 ` Daniel Vetter
2020-02-25 15:16 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222175433.2259158-1-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=Hawking.Zhang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=hdegoede@redhat.com \
--cc=marek.olsak@amd.com \
--cc=tianci.yin@amd.com \
--cc=xiaojie.yuan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).