From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
dri-devel@lists.freedesktop.org, Guan Xuetao <gxt@pku.edu.cn>
Subject: Re: [PATCH v3] backlight: pwm_bl: Switch to full GPIO descriptor
Date: Mon, 24 Feb 2020 10:23:32 +0000 [thread overview]
Message-ID: <20200224102332.GM3494@dell> (raw)
In-Reply-To: <20200210101546.287565-1-linus.walleij@linaro.org>
On Mon, 10 Feb 2020, Linus Walleij wrote:
> The PWM backlight still supports passing a enable GPIO line as
> platform data using the legacy <linux/gpio.h> API.
>
> It turns out that ever board using this mechanism except one
> is pass .enable_gpio = -1. So we drop all these cargo-culted -1's
> from all instances of this platform data in the kernel.
>
> The remaning board, Palm TC, is converted to pass a machine
> descriptior table with the "enable" GPIO instead, and delete the
> platform data entry for enable_gpio and the code handling it
> and things should work smoothly with the new API.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Guan Xuetao <gxt@pku.edu.cn>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Are we waiting on anyone else?
> ---
> ChangeLog v2->v3:
> - Collect Robert's ACK.
> ChangeLog v1->v2:
> - Located a missing removal of .enable_gpio in the Palm TC
> board file, pointed out by Daniel.
> - Grepped to ascertain there is not a single instance of
> the string "enable_gpio" in the affected board files.
> ---
> arch/arm/mach-pxa/cm-x300.c | 1 -
> arch/arm/mach-pxa/colibri-pxa270-income.c | 1 -
> arch/arm/mach-pxa/ezx.c | 1 -
> arch/arm/mach-pxa/hx4700.c | 1 -
> arch/arm/mach-pxa/lpd270.c | 1 -
> arch/arm/mach-pxa/magician.c | 1 -
> arch/arm/mach-pxa/mainstone.c | 1 -
> arch/arm/mach-pxa/mioa701.c | 1 -
> arch/arm/mach-pxa/palm27x.c | 1 -
> arch/arm/mach-pxa/palmtc.c | 11 ++++++++++-
> arch/arm/mach-pxa/palmte2.c | 1 -
> arch/arm/mach-pxa/pcm990-baseboard.c | 1 -
> arch/arm/mach-pxa/tavorevb.c | 2 --
> arch/arm/mach-pxa/viper.c | 1 -
> arch/arm/mach-pxa/z2.c | 2 --
> arch/arm/mach-pxa/zylonite.c | 1 -
> arch/arm/mach-s3c24xx/mach-h1940.c | 1 -
> arch/arm/mach-s3c24xx/mach-rx1950.c | 1 -
> arch/arm/mach-s3c64xx/dev-backlight.c | 3 ---
> arch/arm/mach-s3c64xx/mach-crag6410.c | 1 -
> arch/arm/mach-s3c64xx/mach-hmt.c | 1 -
> arch/arm/mach-s3c64xx/mach-smartq.c | 1 -
> arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +-
> arch/unicore32/kernel/puv3-nb0916.c | 1 -
> drivers/video/backlight/pwm_bl.c | 19 -------------------
> include/linux/pwm_backlight.h | 2 --
> 26 files changed, 11 insertions(+), 49 deletions(-)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-24 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:15 [PATCH v3] backlight: pwm_bl: Switch to full GPIO descriptor Linus Walleij
2020-02-10 14:01 ` Daniel Thompson
2020-02-10 14:29 ` Krzysztof Kozlowski
2020-02-24 10:23 ` Lee Jones [this message]
2020-03-18 15:17 ` [GIT PULL] Immutable branch between Backlight, Arm, Unicore32 and PWM due for the v5.7 merge window Lee Jones
2020-03-19 15:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224102332.GM3494@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gxt@pku.edu.cn \
--cc=jingoohan1@gmail.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).