From: Sam Ravnborg <sam@ravnborg.org>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Mark Rutland <mark.rutland@arm.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Thierry Reding <thierry.reding@gmail.com>,
intel-gfx-trybot@lists.freedesktop.org, kernel@collabora.com,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v10 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation
Date: Tue, 25 Feb 2020 07:15:43 +0100 [thread overview]
Message-ID: <20200225061543.GA9944@ravnborg.org> (raw)
In-Reply-To: <20200224230322.GE16163@pendragon.ideasonboard.com>
Hi Boris/Laurent.
> > +
> > + err = of_property_read_u32(np, "bus-width", &input_bus_width);
> > + of_node_put(np);
> > +
> > + if (err) {
> > + lvds_codec->input_fmt = MEDIA_BUS_FMT_FIXED;
> > + } else if (input_bus_width == 18) {
> > + lvds_codec->input_fmt = MEDIA_BUS_FMT_RGB666_1X18;
> > + } else if (input_bus_width == 24) {
> > + lvds_codec->input_fmt = MEDIA_BUS_FMT_RGB888_1X24;
> > + } else {
> > + dev_dbg(dev, "unsupported bus-width value %u on port 0\n",
> > + input_bus_width);
> > + return -ENOTSUPP;
>
> ENOTSUPP is "Operation not supported", I'd go for -EINVAL.
>
> > + }
>
> Doesn't this apply to LVDS encoders only ? For LVDS decoders I don't
> think we want to report an RGB format on the input.
In panel-lvds we use the property "data-mapping" for the same purpose.
To specify the MEDIA_BUS format.
It would be good to standardize on the same property, and maybe have the
same binding descriptions for all.
And "data-mapping" is a text string, which gives us more flexibility
than just a number, that for MEDIA_BUS_FMT seems required.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-25 6:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 13:55 [PATCH v10 00/12] drm: Add support for bus-format negotiation Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 01/12] drm/bridge: Add a drm_bridge_state object Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 02/12] drm/rcar-du: Plug atomic state hooks to the default implementation Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 03/12] drm/bridge: analogix: " Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 04/12] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 05/12] drm/bridge: Add an ->atomic_check() hook Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 06/12] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 07/12] drm/imx: pd: Use bus format/flags provided by the bridge when available Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation Boris Brezillon
2020-02-24 23:03 ` Laurent Pinchart
2020-02-25 6:15 ` Sam Ravnborg [this message]
2020-02-25 8:44 ` Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 09/12] dt-bindings: display: bridge: lvds-codec: Add new bus-width prop Boris Brezillon
2020-01-31 17:12 ` Sam Ravnborg
2020-01-31 17:23 ` Boris Brezillon
2020-02-24 22:31 ` Laurent Pinchart
2020-02-25 9:13 ` Boris Brezillon
2020-03-09 10:35 ` Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 10/12] drm/bridge: panel: Propage bus format/flags Boris Brezillon
2020-01-31 17:25 ` Boris Brezillon
2020-02-24 22:34 ` Laurent Pinchart
2020-02-25 8:45 ` Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 11/12] drm/panel: simple: Fix the lt089ac29000 bus_format Boris Brezillon
2020-01-28 13:55 ` [PATCH v10 12/12] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition Boris Brezillon
2020-01-31 15:42 ` [PATCH v10 00/12] drm: Add support for bus-format negotiation Boris Brezillon
2020-01-31 16:51 ` Sam Ravnborg
2020-01-31 18:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225061543.GA9944@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.hajda@samsung.com \
--cc=andrew.smirnov@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx-trybot@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).