From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
To: jani.nikula@linux.intel.com, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>,
Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
John Harrison <John.C.Harrison@Intel.com>,
Kenneth Graunke <kenneth@whitecape.org>
Cc: pankaj.laxminarayan.bharadiya@intel.com
Subject: [Intel-gfx][PATCH 09/10] drm/i915/gt: Make MISSING_CASE backtrace i915 specific
Date: Tue, 25 Feb 2020 19:17:08 +0530 [thread overview]
Message-ID: <20200225134709.6153-10-pankaj.laxminarayan.bharadiya@intel.com> (raw)
In-Reply-To: <20200225134709.6153-1-pankaj.laxminarayan.bharadiya@intel.com>
i915_MISSING_CASE macro includes the device information in the
backtrace, so we know what device the warnings originate from.
Covert MISSING_CASE calls with i915 specific i915_MISSING_CASE variant
in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automatically with below coccinelle semantic
patch.
@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<...
-MISSING_CASE(
+i915_MISSING_CASE(T,
...)
...>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<...
-MISSING_CASE(
+i915_MISSING_CASE(T,
...)
...>
}
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 887e0dc701f7..8a80a132f0fe 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -635,7 +635,7 @@ __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
else if (INTEL_GEN(i915) < 8)
return;
else
- MISSING_CASE(INTEL_GEN(i915));
+ i915_MISSING_CASE(i915, INTEL_GEN(i915));
wa_init_finish(wal);
}
@@ -965,7 +965,7 @@ gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
else if (INTEL_GEN(i915) <= 8)
return;
else
- MISSING_CASE(INTEL_GEN(i915));
+ i915_MISSING_CASE(i915, INTEL_GEN(i915));
}
void intel_gt_init_workarounds(struct drm_i915_private *i915)
@@ -1296,7 +1296,7 @@ void intel_engine_init_whitelist(struct intel_engine_cs *engine)
else if (INTEL_GEN(i915) <= 8)
return;
else
- MISSING_CASE(INTEL_GEN(i915));
+ i915_MISSING_CASE(i915, INTEL_GEN(i915));
wa_init_finish(w);
}
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-25 13:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:46 [Intel-gfx][PATCH 00/10] drm/i915: Introduce i915 based i915_MISSING_CASE macro and us it in i915 Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro Pankaj Bharadiya
2020-02-25 14:01 ` Chris Wilson
2020-02-27 6:33 ` Laxminarayan Bharadiya, Pankaj
2020-02-27 8:29 ` Jani Nikula
2020-02-28 5:02 ` Laxminarayan Bharadiya, Pankaj
2020-02-25 13:47 ` [Intel-gfx][PATCH 02/10] drm/i915/display/cdclk: Make MISSING_CASE backtrace i915 specific Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 03/10] drm/i915/display/ddi: " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 04/10] drm/i915/display/display: " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 05/10] drm/i915/dp: " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 06/10] drm/i915/display/hdmi: " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 07/10] drm/i915/display: " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 08/10] drm/i915/gem: " Pankaj Bharadiya
2020-02-25 13:47 ` Pankaj Bharadiya [this message]
2020-02-25 13:47 ` [Intel-gfx][PATCH 10/10] drm/i915: " Pankaj Bharadiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225134709.6153-10-pankaj.laxminarayan.bharadiya@intel.com \
--to=pankaj.laxminarayan.bharadiya@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kenneth@whitecape.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=mika.kuoppala@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).