From: Daniel Thompson <daniel.thompson@linaro.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
kernel-janitors@vger.kernel.org,
Jingoo Han <jingoohan1@gmail.com>, Bryan Wu <cooloney@gmail.com>,
Gyungoh Yoo <jack.yoo@skyworksinc.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing
Date: Fri, 28 Feb 2020 16:45:53 +0000 [thread overview]
Message-ID: <20200228164553.eojh3hbrymq3tw2d@holly.lan> (raw)
In-Reply-To: <b0e21719-3a7c-099a-292d-c3fa65a84fe8@canonical.com>
On Thu, Feb 27, 2020 at 03:10:43PM +0000, Colin Ian King wrote:
> On 27/02/2020 11:46, Daniel Thompson wrote:
> > On Wed, Feb 26, 2020 at 07:58:26PM +0000, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> In the unlikely event that num_entry is zero, the while loop
> >> pre-decrements num_entry to cause negative array indexing into the
> >> array sources. Fix this by iterating only if num_entry >= 0.
> >>
> >> Addresses-Coverity: ("Out-of-bounds read")
> >> Fixes: f705806c9f35 ("backlight: Add support Skyworks SKY81452 backlight driver")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >>
> >> V2: fix typo in commit subject line
> >
> > Isn't the correct spelling "ensure"?
>
> It is. V1 is correct after all. Doh.
It wasn't spelt "ensure" in v1...
Daniel.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-28 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 19:58 [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing Colin King
2020-02-27 11:15 ` AW: " Walter Harms
2020-02-27 11:46 ` Daniel Thompson
2020-02-27 14:57 ` Daniel Thompson
2020-02-27 15:10 ` Colin Ian King
2020-02-28 16:45 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228164553.eojh3hbrymq3tw2d@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=cooloney@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack.yoo@skyworksinc.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).