From: Sam Ravnborg <sam@ravnborg.org>
To: Krishna Manikandan <mkrishn@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
seanpaul@chromium.org, kalyan_t@codeaurora.org,
hoegsberg@chromium.org, freedreno@lists.freedesktop.org
Subject: Re: [v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
Date: Sat, 7 Mar 2020 12:40:54 +0100 [thread overview]
Message-ID: <20200307114054.GA564@ravnborg.org> (raw)
In-Reply-To: <1583494560-25336-1-git-send-email-mkrishn@codeaurora.org>
Hi Krishna.
Thanks for these bindings files.
On Fri, Mar 06, 2020 at 05:06:00PM +0530, Krishna Manikandan wrote:
> MSM Mobile Display Subsytem(MDSS) encapsulates sub-blocks
> like DPU display controller, DSI etc. Add YAML schema
> for the device tree bindings for the same.
>
> Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
> ---
> .../bindings/display/msm/dpu-sc7180.yaml | 269 +++++++++++++++
> .../bindings/display/msm/dpu-sdm845.yaml | 265 +++++++++++++++
> .../bindings/display/msm/dsi-sc7180.yaml | 369 +++++++++++++++++++++
> .../bindings/display/msm/dsi-sdm845.yaml | 369 +++++++++++++++++++++
> 4 files changed, 1272 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sc7180.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-sdm845.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> new file mode 100644
> index 0000000..3d1d9b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> @@ -0,0 +1,269 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Description of Qualcomm Display Dpu dt properties.
Try to be cossistent in capitilization of Dpu versus DPU
> +
> +maintainers:
> + - Krishna Manikandan <mkrishn@codeaurora.org>
> +
> +description: |
> + Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates
> + sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
> + bindings of MDSS and DPU are mentioned for SC7180 target.
Bindings should use an indent of two spaces.
This is what is used in the example schema and the de-facto standard.
One space indent makes it very hard to follow the indent.
For examples the indent varies. From 2 spaces to 8 spaces.
I often use 4 spaces as 2 spaces is not enough when it spans several
lines. But there is nothing fixed there.
> +
> +properties:
> + "mdss":
> + type: object
> + description: |
> + Node containing MDSS that encapsulated sub-blocks like DPU, DSI and DP
> + interfaces.
> +
> + properties:
> + compatible:
> + items:
> + - const: qcom,sc7180-mdss
> + reg:
> + description: |
> + Physical base address and length of controller's registers.
Add empty line between properties (empty line before reg:).
> +
> + reg-names:
> + description: |
> + Names for different register regions defined above. The required region
> + is mentioned below.
> + items:
> + - const: mdss
> +
> + power-domains:
> + description: |
> + A power domain consumer specifier according to
> + Documentation/devicetree/bindings/power/power_domain.txt.
Should this be power-domain.yaml?
> +
> + clocks:
> + description: |
> + List of clock specifiers for clocks needed by the device.
Do not use "|" unless required. Fine to have text on same line as
description: .
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-07 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 11:36 [v1] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings Krishna Manikandan
2020-03-07 11:40 ` Sam Ravnborg [this message]
2020-03-09 18:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307114054.GA564@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).