dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/1]: dt-bindings: display: fix panel warnings
@ 2020-03-08 11:50 Sam Ravnborg
  2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
  0 siblings, 1 reply; 7+ messages in thread
From: Sam Ravnborg @ 2020-03-08 11:50 UTC (permalink / raw)
  To: Rob Herring, dri-devel, devicetree
  Cc: Benjamin Gaignard, Heiko Stuebner, Thierry Reding,
	Laurent Pinchart, Sam Ravnborg

While experiemnting with latest kbuild changes for DT Schema
support there was a couple a new warnings - in may use-case where
I only check one binding file.

Fix the warnings in display/panel/
There are plenty more to go after in other directories, which I
have left for others to have fun with.

Patch is on top of drm-misc-next, where it will be applied once acked/reviewed.

	Sam

Sam Ravnborg (1):
      dt-bindings: display: fix panel warnings

 Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml   | 2 +-
 .../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml       | 2 +-
 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml  | 4 ++--
 .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml         | 2 +-
 Documentation/devicetree/bindings/display/panel/panel-dpi.yaml        | 2 +-
 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 +-
 Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml  | 2 +-
 .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml         | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-08 11:50 [PATCH v1 0/1]: dt-bindings: display: fix panel warnings Sam Ravnborg
@ 2020-03-08 11:50 ` Sam Ravnborg
  2020-03-12  9:45   ` Linus Walleij
                     ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Sam Ravnborg @ 2020-03-08 11:50 UTC (permalink / raw)
  To: Rob Herring, dri-devel, devicetree
  Cc: Benjamin Gaignard, Heiko Stuebner, Thierry Reding,
	Laurent Pinchart, Sam Ravnborg

Fix following type af warnings in the panel bindings:

Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property

Removing the "@xxx" from the node name fixed first warning.
Adding a missing reg property fixed the second warning

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
 .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
 .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
 .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
 .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
 .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
 .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
 .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
index 4bd74eaa61be..aa761f697b7a 100644
--- a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
+++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
index 4ebcea7d0c63..2c9b8aa34815 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index 791fc9daa68b..73d2ff3baaff 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -40,10 +40,10 @@ examples:
   - |
     #include <dt-bindings/gpio/gpio.h>
 
-    dsi@a0351000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
-        panel {
+        panel@0 {
             compatible = "hydis,hva40wv1", "novatek,nt35510";
             reg = <0>;
             vdd-supply = <&ab8500_ldo_aux4_reg>;
diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
index 6e6ac995c27b..4b6dda6dbc0f 100644
--- a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
@@ -39,7 +39,7 @@ required:
 
 examples:
   - |
-    dsi@0 {
+    dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {
diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
index 5275d350f8cb..f63870384c00 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
@@ -48,7 +48,7 @@ additionalProperties: false
 
 examples:
   - |
-    panel@0 {
+    panel {
         compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
         label = "osddisplay";
         power-supply = <&vcc_supply>;
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index 8b60368a2425..cefe19b6bf44 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -50,7 +50,7 @@ required:
 
 examples:
   - |
-    mdss_dsi@fd922800 {
+    mdss_dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
index 09149f140d5f..a35ba16fc000 100644
--- a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
@@ -42,7 +42,7 @@ required:
 
 examples:
   - |
-    dsi@0 {
+    dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {
diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
index 186e5e1c8fa3..39ec7ae525ad 100644
--- a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
+++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
@ 2020-03-12  9:45   ` Linus Walleij
  2020-03-12 10:21   ` Benjamin GAIGNARD
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2020-03-12  9:45 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Benjamin Gaignard,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Heiko Stuebner, Thierry Reding, open list:DRM PANEL DRIVERS,
	Laurent Pinchart

On Sun, Mar 8, 2020 at 12:50 PM Sam Ravnborg <sam@ravnborg.org> wrote:

> Fix following type af warnings in the panel bindings:
>
> Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
>
> Removing the "@xxx" from the node name fixed first warning.
> Adding a missing reg property fixed the second warning
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
  2020-03-12  9:45   ` Linus Walleij
@ 2020-03-12 10:21   ` Benjamin GAIGNARD
  2020-03-12 13:13     ` Rob Herring
  2020-03-12 13:19   ` Rob Herring
  2020-03-14  7:26   ` Sam Ravnborg
  3 siblings, 1 reply; 7+ messages in thread
From: Benjamin GAIGNARD @ 2020-03-12 10:21 UTC (permalink / raw)
  To: Sam Ravnborg, Rob Herring, dri-devel, devicetree
  Cc: Heiko Stuebner, Thierry Reding, Laurent Pinchart



On 3/8/20 12:50 PM, Sam Ravnborg wrote:
> Fix following type af warnings in the panel bindings:
>
> Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
>
> Removing the "@xxx" from the node name fixed first warning.
> Adding a missing reg property fixed the second warning
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I will add W=1 in my command line when check the yaml files to not 
reproduce this later.

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>

Thanks,
Benjamin

> ---
>   .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
>   .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
>   .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
>   .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
>   .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
>   .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
>   .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
>   .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
>   8 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> index 4bd74eaa61be..aa761f697b7a 100644
> --- a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> @@ -34,7 +34,7 @@ additionalProperties: false
>   
>   examples:
>     - |
> -    dsi@ff450000 {
> +    dsi {
>           #address-cells = <1>;
>           #size-cells = <0>;
>           panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> index 4ebcea7d0c63..2c9b8aa34815 100644
> --- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> @@ -34,7 +34,7 @@ additionalProperties: false
>   
>   examples:
>     - |
> -    dsi@ff450000 {
> +    dsi {
>           #address-cells = <1>;
>           #size-cells = <0>;
>           panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index 791fc9daa68b..73d2ff3baaff 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -40,10 +40,10 @@ examples:
>     - |
>       #include <dt-bindings/gpio/gpio.h>
>   
> -    dsi@a0351000 {
> +    dsi {
>           #address-cells = <1>;
>           #size-cells = <0>;
> -        panel {
> +        panel@0 {
>               compatible = "hydis,hva40wv1", "novatek,nt35510";
>               reg = <0>;
>               vdd-supply = <&ab8500_ldo_aux4_reg>;
> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> index 6e6ac995c27b..4b6dda6dbc0f 100644
> --- a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> @@ -39,7 +39,7 @@ required:
>   
>   examples:
>     - |
> -    dsi@0 {
> +    dsi {
>         #address-cells = <1>;
>         #size-cells = <0>;
>         panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> index 5275d350f8cb..f63870384c00 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> @@ -48,7 +48,7 @@ additionalProperties: false
>   
>   examples:
>     - |
> -    panel@0 {
> +    panel {
>           compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
>           label = "osddisplay";
>           power-supply = <&vcc_supply>;
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index 8b60368a2425..cefe19b6bf44 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -50,7 +50,7 @@ required:
>   
>   examples:
>     - |
> -    mdss_dsi@fd922800 {
> +    mdss_dsi {
>         #address-cells = <1>;
>         #size-cells = <0>;
>         panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
> index 09149f140d5f..a35ba16fc000 100644
> --- a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
> @@ -42,7 +42,7 @@ required:
>   
>   examples:
>     - |
> -    dsi@0 {
> +    dsi {
>         #address-cells = <1>;
>         #size-cells = <0>;
>         panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> index 186e5e1c8fa3..39ec7ae525ad 100644
> --- a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> @@ -34,7 +34,7 @@ additionalProperties: false
>   
>   examples:
>     - |
> -    dsi@ff450000 {
> +    dsi {
>           #address-cells = <1>;
>           #size-cells = <0>;
>           panel@0 {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-12 10:21   ` Benjamin GAIGNARD
@ 2020-03-12 13:13     ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-03-12 13:13 UTC (permalink / raw)
  To: Benjamin GAIGNARD
  Cc: devicetree, Heiko Stuebner, dri-devel, Thierry Reding,
	Sam Ravnborg, Laurent Pinchart

On Thu, Mar 12, 2020 at 5:21 AM Benjamin GAIGNARD
<benjamin.gaignard@st.com> wrote:
>
>
>
> On 3/8/20 12:50 PM, Sam Ravnborg wrote:
> > Fix following type af warnings in the panel bindings:
> >
> > Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
> > Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
> >
> > Removing the "@xxx" from the node name fixed first warning.
> > Adding a missing reg property fixed the second warning
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I will add W=1 in my command line when check the yaml files to not
> reproduce this later.

No need to starting in 5.7.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
  2020-03-12  9:45   ` Linus Walleij
  2020-03-12 10:21   ` Benjamin GAIGNARD
@ 2020-03-12 13:19   ` Rob Herring
  2020-03-14  7:26   ` Sam Ravnborg
  3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2020-03-12 13:19 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: devicetree, Benjamin Gaignard, Heiko Stuebner, Thierry Reding,
	dri-devel, Laurent Pinchart

On Sun, Mar 8, 2020 at 6:50 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Fix following type af warnings in the panel bindings:
>
> Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
>
> Removing the "@xxx" from the node name fixed first warning.
> Adding a missing reg property fixed the second warning
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
>  .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
>  .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
>  .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
>  .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
>  .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
>  .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
>  .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
>  8 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> index 4bd74eaa61be..aa761f697b7a 100644
> --- a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
> @@ -34,7 +34,7 @@ additionalProperties: false
>
>  examples:
>    - |
> -    dsi@ff450000 {
> +    dsi {
>          #address-cells = <1>;
>          #size-cells = <0>;
>          panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> index 4ebcea7d0c63..2c9b8aa34815 100644
> --- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> @@ -34,7 +34,7 @@ additionalProperties: false
>
>  examples:
>    - |
> -    dsi@ff450000 {
> +    dsi {
>          #address-cells = <1>;
>          #size-cells = <0>;
>          panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index 791fc9daa68b..73d2ff3baaff 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -40,10 +40,10 @@ examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
>
> -    dsi@a0351000 {
> +    dsi {
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        panel {
> +        panel@0 {
>              compatible = "hydis,hva40wv1", "novatek,nt35510";
>              reg = <0>;
>              vdd-supply = <&ab8500_ldo_aux4_reg>;
> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> index 6e6ac995c27b..4b6dda6dbc0f 100644
> --- a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> @@ -39,7 +39,7 @@ required:
>
>  examples:
>    - |
> -    dsi@0 {
> +    dsi {
>        #address-cells = <1>;
>        #size-cells = <0>;
>        panel@0 {
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> index 5275d350f8cb..f63870384c00 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
> @@ -48,7 +48,7 @@ additionalProperties: false
>
>  examples:
>    - |
> -    panel@0 {
> +    panel {
>          compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
>          label = "osddisplay";
>          power-supply = <&vcc_supply>;
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index 8b60368a2425..cefe19b6bf44 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -50,7 +50,7 @@ required:
>
>  examples:
>    - |
> -    mdss_dsi@fd922800 {
> +    mdss_dsi {

dsi {

With that,

Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings
  2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
                     ` (2 preceding siblings ...)
  2020-03-12 13:19   ` Rob Herring
@ 2020-03-14  7:26   ` Sam Ravnborg
  3 siblings, 0 replies; 7+ messages in thread
From: Sam Ravnborg @ 2020-03-14  7:26 UTC (permalink / raw)
  To: Rob Herring, dri-devel, devicetree
  Cc: Benjamin Gaignard, Heiko Stuebner, Thierry Reding, Laurent Pinchart

On Sun, Mar 08, 2020 at 12:50:17PM +0100, Sam Ravnborg wrote:
> Fix following type af warnings in the panel bindings:
> 
> Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
> 
> Removing the "@xxx" from the node name fixed first warning.
> Adding a missing reg property fixed the second warning
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied and pushed to drm-misc-next with Rob's fix.
Thanks for the reviews!

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-14  7:26 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 11:50 [PATCH v1 0/1]: dt-bindings: display: fix panel warnings Sam Ravnborg
2020-03-08 11:50 ` [PATCH v1 1/1] " Sam Ravnborg
2020-03-12  9:45   ` Linus Walleij
2020-03-12 10:21   ` Benjamin GAIGNARD
2020-03-12 13:13     ` Rob Herring
2020-03-12 13:19   ` Rob Herring
2020-03-14  7:26   ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).