From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F11C18E5A for ; Tue, 10 Mar 2020 12:07:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 225012468F for ; Tue, 10 Mar 2020 12:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 225012468F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF2806E1CE; Tue, 10 Mar 2020 12:07:42 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id A551C6E1CE for ; Tue, 10 Mar 2020 12:07:41 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 05:07:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,536,1574150400"; d="scan'208";a="234330305" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga007.fm.intel.com with SMTP; 10 Mar 2020 05:07:38 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 10 Mar 2020 14:07:37 +0200 Date: Tue, 10 Mar 2020 14:07:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "H. Nikolaus Schaller" Subject: Re: [PATCH] drm/panel-simple: Fix dotclock for Ortustech COM37H3M Message-ID: <20200310120737.GC13686@intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , letux-kernel@openphoenux.org, Sam Ravnborg Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 10, 2020 at 08:43:19AM +0100, H. Nikolaus Schaller wrote: > The currently listed dotclock disagrees with the currently > listed vrefresh rate. Change the dotclock to match the vrefresh. > = > There are two variants of the COM37H3M panel. > The older one's COM37H3M05DTC data sheet specifies: > = > MIN TYP MAX > CLK frequency fCLK -- 22.4 26.3 MHz (in VGA mode) > VSYNC Frequency fVSYNC 54 60 66 Hz > VSYNC cycle time tv -- 650 -- H > HSYNC frequency fHSYNC -- 39.3 -- kHz > HSYNC cycle time th -- 570 -- CLK > = > The newer one's COM37H3M99DTC data sheet says: > = > MIN TYP MAX > CLK frequency fCLK 18 19.8 27 MHz > VSYNC Frequency fVSYNC 54 60 66 Hz > VSYNC cycle time tv 646 650 700 H > HSYNC frequency fHSYNC -- 39.0 50.0 kHz > HSYNC cycle time th 504 508 630 CLK > = > So we choose a parameter set that lies within the specs > of both variants. We start at .vrefresh =3D 60, > choose .htotal =3D 570 and .vtotal =3D 650 and end up > in a clock of 22.230 MHz. > = > Reported-by: Ville Syrjala > Signed-off-by: H. Nikolaus Schaller > --- > drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > = > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index e14c14ac62b5..b4cb23d4898d 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2390,15 +2390,15 @@ static const struct panel_desc ontat_yx700wv03 = =3D { > }; > = > static const struct drm_display_mode ortustech_com37h3m_mode =3D { > - .clock =3D 22153, > + .clock =3D 22230, > .hdisplay =3D 480, > - .hsync_start =3D 480 + 8, > - .hsync_end =3D 480 + 8 + 10, > - .htotal =3D 480 + 8 + 10 + 10, > + .hsync_start =3D 480 + 40, > + .hsync_end =3D 480 + 40 + 10, > + .htotal =3D 480 + 40 + 10 + 40, > .vdisplay =3D 640, > .vsync_start =3D 640 + 4, > - .vsync_end =3D 640 + 4 + 3, > - .vtotal =3D 640 + 4 + 3 + 4, > + .vsync_end =3D 640 + 4 + 2, > + .vtotal =3D 640 + 4 + 2 + 4, > .vrefresh =3D 60, Numbers look consistent. Reviewed-by: Ville Syrj=E4l=E4 > .flags =3D DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > }; > -- = > 2.23.0 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel