From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D342C10DCE for ; Fri, 13 Mar 2020 13:38:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4185F206B7 for ; Fri, 13 Mar 2020 13:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="smtnXpub" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4185F206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 815D56E9B1; Fri, 13 Mar 2020 13:38:10 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9076E6E9B1 for ; Fri, 13 Mar 2020 13:38:08 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 280965F; Fri, 13 Mar 2020 14:38:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584106687; bh=UBN5Umy01Tm7Cv8bTD62fblJWwI6SoHXtxhg5W5LvNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=smtnXpubTKQashwIDR5/CTWgxM8e1l3xFLtYBsnKRFJS52Z+kc0763HiWcTlAku3+ YUalUcrECEQ2RweOJGfgxKzcRsCa68N16V4A1jFtLrmkWcFEpofEspE3wRRRLADXNz jwR9YaSYke7miywLZ/00yQkLFOTrVO/Y4+idHEPo= Date: Fri, 13 Mar 2020 15:38:03 +0200 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH] omapfb: Remove unused writeback code Message-ID: <20200313133803.GA9070@pendragon.ideasonboard.com> References: <20200313122410.7528-1-tomi.valkeinen@ti.com> <20200313132244.GB4751@pendragon.ideasonboard.com> <249364fc-bc83-6fe6-d3bf-f709505c299e@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <249364fc-bc83-6fe6-d3bf-f709505c299e@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi, On Fri, Mar 13, 2020 at 03:30:15PM +0200, Tomi Valkeinen wrote: > On 13/03/2020 15:22, Laurent Pinchart wrote: > > On Fri, Mar 13, 2020 at 02:24:10PM +0200, Tomi Valkeinen wrote: > >> Remove unused writeback code. This code will never be used, as omapfb is > >> being deprecated. > > > > I'm fine with that, but out of curiosity, is there any particular reason > > to remove that code now instead of letting omapfb bitrot slowly ? > > It conflicts with tidss's writeback code in TI kernel, when compiling tidss and omapfb into the > kernel. I thought this is the easiest way to resolve that, as all the removed code is dead code, > instead of trying to invent new names in tidss for a lot of functions. > > Probably the functions in tidss still could use some renaming in the future, but I didn't want to be > forced to do that because of omapfb's dead code... Could you do both ? :-) It's not good using too generic names in tidss. You can just prefix the functions with tidss_. There's a risk of conflict with omapdrm too if the names are too generic. > So, not a super good reason, but on the other hand, removing dead code is always a good thing. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel