From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA1EAC1975A for ; Mon, 16 Mar 2020 08:33:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C7B420658 for ; Mon, 16 Mar 2020 08:33:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="bqhZBq8g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C7B420658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28FB66E373; Mon, 16 Mar 2020 08:33:15 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id F02B06E373 for ; Mon, 16 Mar 2020 08:33:13 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id f3so13008477wrw.7 for ; Mon, 16 Mar 2020 01:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Np0PyQ3dN/K0XmXOWBC7J7/OCl/vL8McW1IXy4RBUgE=; b=bqhZBq8gCbsRh+Ix9GzmFj7etr9aCj5k2VDWtb9DCZDwiUCQ4xy5s1cpMAc2jIBpCo WwxG0+8bynS7HTBvZ+IMWiWgLzWMCoq2Jcy6TDEG7/yEMjhTa16mzIVokPevbP+2vpVz /IfRIBrdLITDf1yOGV5zCQasJlEzEhPdG8440= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Np0PyQ3dN/K0XmXOWBC7J7/OCl/vL8McW1IXy4RBUgE=; b=NBU4OsFGAkseuUSJT4rLqvf2OzhnrKlmxYoiG1aZCHPOLupBfittg+T/fc1bS7uFHz bUOW8AOsF5BG3DHFnZfaE+TWK1335f2VeEKLi6ZpuRTPsrJFautaqc2iCqG7dAQf7shy p6EmAgJXEstcaWRpe1zGzX1XHV59uNGtnRRtv5xA7pocx0OovkLCD+EKlmv7eHl5XXX5 fmusk14TmGXWW0pPVPC978FT/S6XQ94jrsyVcPpBSBWF/YSP+NqMIOs3hQFNEfYzc+vq H9mlUvNdDRQoue7pd1yv0N27M8/Ytu54fFXYyIVlMtb7o9yWJCqHy29j8hhBdqibBXe1 Rr9w== X-Gm-Message-State: ANhLgQ2at0HF5XOmySr5rjW8XSJIu96EHf6BncfS6gHstGvEbpZjNSGy 0XAchLbGKPOULe9BozyJoBoqEg== X-Google-Smtp-Source: ADFU+vv5wVdXdcx4EeLmKazJGTmA1SjA1iRGsWULv81fmZZvk3NWZudyD95lysFKRly5AByJQvUxng== X-Received: by 2002:a5d:6907:: with SMTP id t7mr19250023wru.159.1584347592539; Mon, 16 Mar 2020 01:33:12 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g7sm93502349wrq.21.2020.03.16.01.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 01:33:11 -0700 (PDT) Date: Mon, 16 Mar 2020 09:33:09 +0100 From: Daniel Vetter To: Thierry Reding Subject: Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value Message-ID: <20200316083309.GD2363188@phenom.ffwll.local> Mail-Followup-To: Thierry Reding , Wambui Karuga , airlied@linux.ie, Jonathan Hunter , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20200227120232.19413-1-wambui.karugax@gmail.com> <20200227120232.19413-11-wambui.karugax@gmail.com> <20200311143753.GC494173@ulmo> <20200311232446.GA998881@ulmo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200311232446.GA998881@ulmo> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonathan Hunter , linux-tegra@vger.kernel.org, Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 12, 2020 at 12:24:46AM +0100, Thierry Reding wrote: > On Wed, Mar 11, 2020 at 05:54:46PM +0300, Wambui Karuga wrote: > > Hey Thierry, > > > > On Wed, 11 Mar 2020, Thierry Reding wrote: > > > > > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote: > > > > Since 987d65d01356 (drm: debugfs: make > > > > drm_debugfs_create_files() never fail) there is no need to check the > > > > return value of drm_debugfs_create_files(). Therefore, remove the > > > > return checks and error handling of the drm_debugfs_create_files() > > > > function from various debugfs init functions in drm/tegra and have > > > > them return 0 directly. > > > > > > > > This change also includes removing the use of drm_debugfs_create_files > > > > as a return value in tegra_debugfs_init() and have the function declared > > > > as void. > > > > > > > > Signed-off-by: Wambui Karuga > > > > --- > > > > drivers/gpu/drm/tegra/dc.c | 11 +---------- > > > > drivers/gpu/drm/tegra/drm.c | 8 ++++---- > > > > drivers/gpu/drm/tegra/dsi.c | 11 +---------- > > > > drivers/gpu/drm/tegra/hdmi.c | 11 +---------- > > > > drivers/gpu/drm/tegra/sor.c | 11 +---------- > > > > 5 files changed, 8 insertions(+), 44 deletions(-) > > > > > > Applied, thanks. > > > > > There's a newer version[1] of this patch series as this specific patch > > depends on other work in drm. > > Oh yeah, I just noticed that this patch causes a build failure, so I > backed it out again. > > If there's dependencies on other work, it's probably best to take this > through drm-misc, in which case: > > Acked-by: Thierry Reding > > Let me know if you'd prefer me to apply this to drm/tegra instead. Yeah I'm going to pull in the entire series through -misc rsn. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel