From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/9] drm: Constify topology id
Date: Wed, 18 Mar 2020 17:56:28 +0200 [thread overview]
Message-ID: <20200318155628.GA13686@intel.com> (raw)
In-Reply-To: <CADnq5_OsVawW3RV+8UhSf-wF0eG4Tp-fOMzsuLfJGJj_aPu-HA@mail.gmail.com>
On Fri, Mar 13, 2020 at 04:05:00PM -0400, Alex Deucher wrote:
> On Fri, Mar 13, 2020 at 12:21 PM Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Make the topology id const since we don't want to change it.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Series is:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks. Series pushed to drm-misc-next.
>
> > ---
> > drivers/gpu/drm/drm_connector.c | 4 ++--
> > include/drm/drm_connector.h | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> > index 644f0ad10671..462d8caa6e72 100644
> > --- a/drivers/gpu/drm/drm_connector.c
> > +++ b/drivers/gpu/drm/drm_connector.c
> > @@ -2392,7 +2392,7 @@ EXPORT_SYMBOL(drm_mode_put_tile_group);
> > * tile group or NULL if not found.
> > */
> > struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,
> > - char topology[8])
> > + const char topology[8])
> > {
> > struct drm_tile_group *tg;
> > int id;
> > @@ -2422,7 +2422,7 @@ EXPORT_SYMBOL(drm_mode_get_tile_group);
> > * new tile group or NULL.
> > */
> > struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev,
> > - char topology[8])
> > + const char topology[8])
> > {
> > struct drm_tile_group *tg;
> > int ret;
> > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> > index 19ae6bb5c85b..fd543d1db9b2 100644
> > --- a/include/drm/drm_connector.h
> > +++ b/include/drm/drm_connector.h
> > @@ -1617,9 +1617,9 @@ struct drm_tile_group {
> > };
> >
> > struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev,
> > - char topology[8]);
> > + const char topology[8]);
> > struct drm_tile_group *drm_mode_get_tile_group(struct drm_device *dev,
> > - char topology[8]);
> > + const char topology[8]);
> > void drm_mode_put_tile_group(struct drm_device *dev,
> > struct drm_tile_group *tg);
> >
> > --
> > 2.24.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-18 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 16:20 [PATCH 0/9] drm/edid: DisplayID parser fixes Ville Syrjala
2020-03-13 16:20 ` [PATCH 1/9] drm: Constify topology id Ville Syrjala
2020-03-13 20:05 ` Alex Deucher
2020-03-18 15:56 ` Ville Syrjälä [this message]
2020-03-13 16:20 ` [PATCH 2/9] drm/edid: Swap some operands in for_each_displayid_db() Ville Syrjala
2020-03-13 16:20 ` [PATCH 3/9] drm/edid: Remove idx==1 assumptions from all over the DispID parsing Ville Syrjala
2020-03-13 16:20 ` [PATCH 4/9] drm/edid: Return DispID length from drm_find_displayid_extension() Ville Syrjala
2020-03-13 16:20 ` [PATCH 5/9] drm/edid: Move validate_displayid() drm_find_displayid_extension() Ville Syrjala
2020-03-13 16:20 ` [PATCH 6/9] drm/edid: Don't parse garbage as DispID blocks Ville Syrjala
2020-03-13 16:20 ` [PATCH 7/9] drm/edid: Don't include ext block csum in DispID size Ville Syrjala
2020-03-13 16:20 ` [PATCH 8/9] drm/edid: Clarify validate_displayid() Ville Syrjala
2020-03-13 16:20 ` [PATCH 9/9] drm/edid: Fix DispID tile parsing for override EDID Ville Syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318155628.GA13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).