From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F96C4332D for ; Thu, 19 Mar 2020 07:55:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28ABE20724 for ; Thu, 19 Mar 2020 07:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AU8yO8xo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28ABE20724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 428056E0F0; Thu, 19 Mar 2020 07:55:28 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 377D16E0F0 for ; Thu, 19 Mar 2020 07:55:27 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8527820722; Thu, 19 Mar 2020 07:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584604527; bh=Kb658nfyPT3JjcT6O6bGNznpEW5TYTVbSSKBWVdtWNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AU8yO8xoV4zZAruiWmYXH054NUb2x5ZsVxmO+TA9YjZBwxNaU16yJMKtu4UVz6Afk 9xETnb5hghwKnCYutwD8hEFjrS3vTqOvX5oxueFpF1xVW75h8YXOziIfvaIy4zGqxI 6+wRVW13Nbqm0tlUVtlWWbdjhkvDfBIXBwrzICrE= Date: Thu, 19 Mar 2020 08:55:24 +0100 From: Greg KH To: Daniel Vetter Subject: Re: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0 Message-ID: <20200319075524.GB3445010@kroah.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> <20200310133121.27913-11-wambui.karugax@gmail.com> <20200318152627.GY2363188@phenom.ffwll.local> <20200318165846.GC3090655@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Linux Kernel Mailing List , dri-devel , Thomas Zimmermann , Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 18, 2020 at 08:10:43PM +0100, Daniel Vetter wrote: > On Wed, Mar 18, 2020 at 5:58 PM Greg KH wrote: > > > > On Wed, Mar 18, 2020 at 05:31:47PM +0100, Daniel Vetter wrote: > > > On Wed, Mar 18, 2020 at 5:03 PM Wambui Karuga wrote: > > > > > > > > > > > > > > > > On Wed, 18 Mar 2020, Daniel Vetter wrote: > > > > > > > > > On Tue, Mar 10, 2020 at 04:31:14PM +0300, Wambui Karuga wrote: > > > > >> Since 987d65d01356 (drm: debugfs: make > > > > >> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > > > > >> fails and should return void. Therefore, remove its use as the > > > > >> return value of drm_vram_mm_debugfs_init(), and have the function > > > > >> return 0 directly. > > > > >> > > > > >> v2: have drm_vram_mm_debugfs_init() return 0 instead of void to avoid > > > > >> introducing build issues and build breakage. > > > > >> > > > > >> References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html > > > > >> Signed-off-by: Wambui Karuga > > > > >> Acked-by: Thomas Zimmermann > > > > >> --- > > > > >> drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++++------ > > > > >> 1 file changed, 4 insertions(+), 6 deletions(-) > > > > >> > > > > >> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > >> index 92a11bb42365..c8bcc8609650 100644 > > > > >> --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > >> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > >> @@ -1048,14 +1048,12 @@ static const struct drm_info_list drm_vram_mm_debugfs_list[] = { > > > > >> */ > > > > >> int drm_vram_mm_debugfs_init(struct drm_minor *minor) > > > > >> { > > > > >> - int ret = 0; > > > > >> - > > > > >> #if defined(CONFIG_DEBUG_FS) > > > > > > > > > > Just noticed that this #if here is not needed, we already have a dummy > > > > > function for that case. Care to write a quick patch to remove it? On top > > > > > of this patch series here ofc, I'm in the processing of merging the entire > > > > > pile. > > > > > > > > > > Thanks, Daniel > > > > Hi Daniel, > > > > Without this check here, and compiling without CONFIG_DEBUG_FS, this > > > > function is run and the drm_debugfs_create_files() does not have access to > > > > the parameters also protected by an #if above this function. So the change > > > > throws an error for me. Is that correct? > > > > > > Hm right. Other drivers don't #ifdef out their debugfs file functions > > > ... kinda a bit disappointing that we can't do this in the neatest way > > > possible. > > > > > > Greg, has anyone ever suggested to convert the debugfs_create_file > > > function (and similar things) to macros that don't use any of the > > > arguments, and then also annotating all the static functions/tables as > > > __maybe_unused and let the compiler garbage collect everything? > > > Instead of explicit #ifdef in all the drivers ... > > > > No, no one has suggested that, having the functions be static inline > > should make it all "just work" properly if debugfs is not enabled. The > > variables will not be used, so the compiler should just optimize them > > away properly. > > > > No checks for CONFIG_DEBUG_FS should be needed anywhere in .c code. > > So the trouble with this one is that the static inline functions for > the debugfs file are wrapped in a #if too, and hence if we drop the > #if around the function call stuff won't compile. Should we drop all > the #if in the .c file and assume the compiler will remove all the > dead code and dead functions? Yes you should :) there should not be any need for #if in a .c file for debugfs stuff. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel