dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	Gurchetan Singh <gurchetansingh@chromium.org>
Subject: Re: [PATCH v3 1/2] drm/virtio: factor out the sg_table from virtio_gpu_object
Date: Thu, 19 Mar 2020 10:47:40 +0100	[thread overview]
Message-ID: <20200319094740.jmjijfj2zk3a4vic@sirius.home.kraxel.org> (raw)
In-Reply-To: <cc18ed7f-3264-0d38-b772-64d79244f52d@gmail.com>

On Thu, Mar 19, 2020 at 10:32:25AM +0100, Jiri Slaby wrote:
> On 05. 03. 20, 2:32, Gurchetan Singh wrote:
> > A resource will be a shmem based resource or a (planned)
> > vram based resource, so it makes sense to factor out common fields
> > (resource handle, dumb).
> > 
> > v2: move mapped field to shmem object
> 
> Hi,
> 
> I bisected the slab-out-of-bounds below to this patch. Is it known?

No.  I suspect sizeof(virtio_gpu_object) instead of
sizeof(virtio_gpu_object_shmem) for allocation, I'll have a look ...

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-03-19  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  1:32 [PATCH v3 1/2] drm/virtio: factor out the sg_table from virtio_gpu_object Gurchetan Singh
2020-03-05  1:32 ` [PATCH v3 2/2] drm/virtio: add case for shmem objects in virtio_gpu_cleanup_object(..) Gurchetan Singh
2020-03-09  9:47 ` [PATCH v3 1/2] drm/virtio: factor out the sg_table from virtio_gpu_object Gerd Hoffmann
2020-03-19  9:32 ` Jiri Slaby
2020-03-19  9:47   ` Gerd Hoffmann [this message]
2020-03-19  9:55     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319094740.jmjijfj2zk3a4vic@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gurchetansingh@chromium.org \
    --cc=jirislaby@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).