From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Ondrej Jirman <megous@megous.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] drm/sun4i: sun6i_mipi_dsi: fix horizontal timing calculation
Date: Thu, 19 Mar 2020 10:54:41 +0100 [thread overview]
Message-ID: <20200319095441.zfaivhnh3pwuphp4@gilmour.lan> (raw)
In-Reply-To: <20200316133503.144650-5-icenowy@aosc.io>
[-- Attachment #1.1: Type: text/plain, Size: 452 bytes --]
Hi,
On Mon, Mar 16, 2020 at 09:35:02PM +0800, Icenowy Zheng wrote:
> The max() function call in horizontal timing calculation shouldn't pad a
> length already subtracted with overhead to overhead, instead it should
> only prevent the set timing to underflow.
Some explanation on why it shouldn't do that would be appreciated.
Also, with the changes you have below, the comments above each max
call don't match anymore and should be updated.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-20 8:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 13:34 [PATCH v2 0/5] Add support for PinePhone LCD panel Icenowy Zheng
2020-03-16 13:34 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add Xingbangda Icenowy Zheng
2020-03-16 13:35 ` [PATCH v2 2/5] dt-bindings: panel: add binding for Xingbangda XBD599 panel Icenowy Zheng
2020-03-19 14:14 ` Linus Walleij
2020-03-20 7:58 ` Icenowy Zheng
2020-03-20 9:11 ` Linus Walleij
2020-03-20 9:21 ` Icenowy Zheng
2020-03-16 13:35 ` [PATCH v2 3/5] drm: panel: add " Icenowy Zheng
2020-03-16 19:11 ` Ondřej Jirman
2020-03-19 14:08 ` Linus Walleij
2020-03-20 9:18 ` Linus Walleij
2020-03-16 13:35 ` [PATCH v2 4/5] drm/sun4i: sun6i_mipi_dsi: fix horizontal timing calculation Icenowy Zheng
2020-03-19 9:54 ` Maxime Ripard [this message]
2020-03-16 13:35 ` [PATCH v2 5/5] arm64: allwinner: dts: a64: add LCD-related device nodes for PinePhone Icenowy Zheng
2020-03-19 14:51 ` [linux-sunxi] " Icenowy Zheng
2020-03-19 16:10 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319095441.zfaivhnh3pwuphp4@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).