From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEECAC3F2CD for ; Mon, 23 Mar 2020 15:38:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A11B720637 for ; Mon, 23 Mar 2020 15:38:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="dEun6e07" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11B720637 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FE1C89E1D; Mon, 23 Mar 2020 15:38:00 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C956489E1D for ; Mon, 23 Mar 2020 15:37:58 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id a81so9578987wmf.5 for ; Mon, 23 Mar 2020 08:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=N3Q+qAIc552rJD7ZSPM4p2mnFuNM9e12XzMy9h14WCY=; b=dEun6e07weqIPfvGZLW2lxQWBnRjAcTPfpJcwnj6VLcaSCQ8E/PNj4jIiO18ld/bFx fp/HLKk5uUVLbdTUICIzqevbrLkIs69s93OpFV+2cB7tICCsHRp4sKldvYa+2v7L++O3 g0PxvKzquB+EPBCoSM3kjpryRp4UairYjg5Qs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=N3Q+qAIc552rJD7ZSPM4p2mnFuNM9e12XzMy9h14WCY=; b=XYZkzIh0qXKLA7G2Iu8/Jpt3sOdoJL5Kos4s2pbq2uaa0oPbCn5JzHg6AOwxGK9wRt QR8He7/BmB3+sVGtvaZg+60fz3MCo7ZlmHR/LEwzkVzPiNGaNp4KufEfbJEJz5tBRtYf N+iMq+YIHNkntSvBH1iVlw9gIe5HAawJ1sov1HsNdY3KJSpMe1y2TMbeDL+Wt2YeP3wd XjSOeRJdVO6+Gr+VH7yDtX9QQEIEzkCRvD6bvxnSb+U1V2WoFi6GoJ6XrXtzXZ4fjICx 5adnLYBeo+gFm+TWBudD7zhmMZP2bI6gjvmH/J8mt2UTMDa8Fgkhk7Llqh+Suu3LW3fw 1GTw== X-Gm-Message-State: ANhLgQ2SDeaIHQ/vAtph9d5doSA1Rs3jRIH9qULrlm/EPuyjy35hJ1Y4 Vpqy6g5Fcqiowz8YOZtp6GBRVg== X-Google-Smtp-Source: ADFU+vvGd1MKe/OvLt2X47KYngeTnpKSj43dHgfDxQAUMDIBGIJ3JQimSSVq6szxlHUK+ouaNN/xLQ== X-Received: by 2002:a7b:c194:: with SMTP id y20mr11877864wmi.163.1584977877362; Mon, 23 Mar 2020 08:37:57 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id k3sm3322699wro.39.2020.03.23.08.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 08:37:55 -0700 (PDT) Date: Mon, 23 Mar 2020 16:37:52 +0100 From: Daniel Vetter To: Greg KH Subject: Re: [PATCH] drm/vram-helper: remove unneeded #if defined/endif guards. Message-ID: <20200323153752.GK2363188@phenom.ffwll.local> Mail-Followup-To: Greg KH , Wambui Karuga , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200323112802.228214-1-wambui.karugax@gmail.com> <20200323113726.GA663867@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200323113726.GA663867@kroah.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tzimmermann@suse.de, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 23, 2020 at 12:37:26PM +0100, Greg KH wrote: > On Mon, Mar 23, 2020 at 02:28:02PM +0300, Wambui Karuga wrote: > > Remove unneeded #if/#endif guards for checking whether the > > CONFIG_DEBUG_FS option is set or not. If the option is not set, the > > compiler optimizes the functions making the guards > > unnecessary. > > > > Signed-off-by: Wambui Karuga Applied, thanks a lot. -Daniel > > --- > > drivers/gpu/drm/drm_gem_vram_helper.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > > index 76506bedac11..b3201a70cbfc 100644 > > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > > @@ -1018,7 +1018,6 @@ static struct ttm_bo_driver bo_driver = { > > * struct drm_vram_mm > > */ > > > > -#if defined(CONFIG_DEBUG_FS) > > static int drm_vram_mm_debugfs(struct seq_file *m, void *data) > > { > > struct drm_info_node *node = (struct drm_info_node *) m->private; > > @@ -1035,7 +1034,6 @@ static int drm_vram_mm_debugfs(struct seq_file *m, void *data) > > static const struct drm_info_list drm_vram_mm_debugfs_list[] = { > > { "vram-mm", drm_vram_mm_debugfs, 0, NULL }, > > }; > > -#endif > > > > /** > > * drm_vram_mm_debugfs_init() - Register VRAM MM debugfs file. > > @@ -1045,11 +1043,9 @@ static const struct drm_info_list drm_vram_mm_debugfs_list[] = { > > */ > > void drm_vram_mm_debugfs_init(struct drm_minor *minor) > > { > > -#if defined(CONFIG_DEBUG_FS) > > drm_debugfs_create_files(drm_vram_mm_debugfs_list, > > ARRAY_SIZE(drm_vram_mm_debugfs_list), > > minor->debugfs_root, minor); > > -#endif > > } > > EXPORT_SYMBOL(drm_vram_mm_debugfs_init); > > > > -- > > 2.25.1 > > Reviewed-by: Greg Kroah-Hartman -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel