From: Jason Gunthorpe <jgg@mellanox.com>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: Philip Yang <Philip.Yang@amd.com>,
John Hubbard <jhubbard@nvidia.com>,
Felix.Kuehling@amd.com, amd-gfx@lists.freedesktop.org,
linux-mm@kvack.org, Jerome Glisse <jglisse@redhat.com>,
dri-devel@lists.freedesktop.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments
Date: Mon, 23 Mar 2020 14:24:39 -0300 [thread overview]
Message-ID: <20200323172439.GA13183@mellanox.com> (raw)
In-Reply-To: <7d7e5bad-8956-775b-1a4c-c927b2464459@nvidia.com>
On Fri, Mar 20, 2020 at 02:46:09PM -0700, Ralph Campbell wrote:
>
> On 3/20/20 9:49 AM, Jason Gunthorpe wrote:
> > From: Jason Gunthorpe <jgg@mellanox.com>
> >
> > Delete several functions that are never called, fix some desync between
> > comments and structure content, remove an unused ret, and move one
> > function only used by hmm.c into hmm.c
> >
> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
>
> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
>
> > include/linux/hmm.h | 50 ---------------------------------------------
> > mm/hmm.c | 12 +++++++++++
> > 2 files changed, 12 insertions(+), 50 deletions(-)
> >
> > diff --git a/include/linux/hmm.h b/include/linux/hmm.h
> > index bb6be4428633a8..184a8633260f9d 100644
> > +++ b/include/linux/hmm.h
> > @@ -120,9 +120,6 @@ enum hmm_pfn_value_e {
> > *
> > * @notifier: a mmu_interval_notifier that includes the start/end
> > * @notifier_seq: result of mmu_interval_read_begin()
> > - * @hmm: the core HMM structure this range is active against
> > - * @vma: the vm area struct for the range
> > - * @list: all range lock are on a list
> > * @start: range virtual start address (inclusive)
> > * @end: range virtual end address (exclusive)
> > * @pfns: array of pfns (big enough for the range)
> > @@ -131,7 +128,6 @@ enum hmm_pfn_value_e {
> > * @default_flags: default flags for the range (write, read, ... see hmm doc)
> > * @pfn_flags_mask: allows to mask pfn flags so that only default_flags matter
> > * @pfn_shifts: pfn shift value (should be <= PAGE_SHIFT)
>
> s/pfn_shifts/pfn_shift
Got it in v2, thanks
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-24 8:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 16:48 [PATCH hmm 0/6] Small hmm_range_fault() cleanups Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 1/6] mm/hmm: remove pgmap checking for devmap pages Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 2/6] mm/hmm: return the fault type from hmm_pte_need_fault() Jason Gunthorpe
[not found] ` <20200321083726.GB28695@lst.de>
2020-03-23 20:14 ` Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments Jason Gunthorpe
2020-03-20 21:46 ` Ralph Campbell
2020-03-23 17:24 ` Jason Gunthorpe [this message]
[not found] ` <20200321083902.GC28695@lst.de>
2020-03-23 17:24 ` Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 4/6] mm/hmm: remove HMM_FAULT_SNAPSHOT Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 5/6] mm/hmm: remove the CONFIG_TRANSPARENT_HUGEPAGE #ifdef Jason Gunthorpe
[not found] ` <20200321084317.GE28695@lst.de>
2020-03-23 17:33 ` Jason Gunthorpe
2020-03-20 16:49 ` [PATCH hmm 6/6] mm/hmm: use device_private_entry_to_pfn() Jason Gunthorpe
[not found] ` <20200321084347.GF28695@lst.de>
2020-03-23 17:44 ` Jason Gunthorpe
2020-03-20 18:51 ` [PATCH hmm 0/6] Small hmm_range_fault() cleanups Ralph Campbell
2020-03-20 18:55 ` Jason Gunthorpe
2020-03-20 21:47 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323172439.GA13183@mellanox.com \
--to=jgg@mellanox.com \
--cc=Felix.Kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).