Re: [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific

[Sam Ravnborg <sam@ravnborg.org>]

Hi Pankaj.

On Tue, Mar 31, 2020 at 12:45:24AM +0530, Pankaj Bharadiya wrote:
> With below commit, we have new struct drm_device based WARN* macros,
> which include device specific information in the backtrace.
> 
> commit dc1a73e50f9c63d4dd928df538082200467dc4b1
> Author: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> Date:   Wed Jan 15 09:14:45 2020 +0530
> 
>     drm/print: introduce new struct drm_device based WARN* macros
> 
> Majority of the i915 WARN* are already converted to use struct
> drm_device specific drm_WARN* calls.Add new todo entry for
Add space after '.'

> pending conversions.
> 
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
>  Documentation/gpu/todo.rst | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 37a3a023c114..0cb32df89784 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -575,6 +575,18 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
>  
>  Contact: Harry Wentland, Alex Deucher
>  
> +Make i915 WARN* Calls struct drm_device Specific
> +------------------------------------------------
> +
> +struct drm_device specific drm_WARN* macros include device information in the
> +backtrace, so we know what device the warnings originate from. Convert all the
> +calls of WARN* with drm_WARN* calls in i915. While at it, remove WARN* which
> +are not truly valid.
> +
> +Contact: Jani Nikula
> +
> +Level: Starter
> +
>  Bootsplash
>  ==========
>  
> @@ -595,7 +607,7 @@ Level: Advanced
>  Outside DRM
>  ===========
>  
> -Convert fbdev drivers to DRM
> +Convert fbdev drivers to 
Unrelated change?

Please fix and re-submit.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel