From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6425BC2BA1E for ; Mon, 6 Apr 2020 11:15:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C9C20780 for ; Mon, 6 Apr 2020 11:15:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NV6V1nFe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C9C20780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 849906E32C; Mon, 6 Apr 2020 11:15:55 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62EC36E32C for ; Mon, 6 Apr 2020 11:15:54 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BF0080E; Mon, 6 Apr 2020 13:15:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586171752; bh=yyEsGrubUp166va2A/YeFJLQbB3EJnYU4das1rpKeNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NV6V1nFeJ04+hy53y3aAiCdcGOrEi9TK2FQhGYTNjSfMMra+GFYjg7biMmrCtZ2A4 Uvt2hoghqV13eyAAx9PnY6J4PqEFNdrYWM6ODZz5LNm5dfG8D6lAKRQuxjZ5vb7mWK b3R+MPTPbYK4UhUOZw8TLm5ijbgEu4BLRj44GgYY= Date: Mon, 6 Apr 2020 14:15:43 +0300 From: Laurent Pinchart To: Jacopo Mondi Subject: Re: [PATCH 3/4] dt-bindings: display: bridge: thc63lvd1024: Convert binding to YAML Message-ID: <20200406111543.GC4757@pendragon.ideasonboard.com> References: <20200405232318.26833-1-laurent.pinchart+renesas@ideasonboard.com> <20200405232318.26833-4-laurent.pinchart+renesas@ideasonboard.com> <20200406064031.huwbq3wqd6t46idq@uno.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200406064031.huwbq3wqd6t46idq@uno.localdomain> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Jacopo Mondi , Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jacopo, On Mon, Apr 06, 2020 at 08:40:31AM +0200, Jacopo Mondi wrote: > On Mon, Apr 06, 2020 at 02:23:17AM +0300, Laurent Pinchart wrote: > > Convert the Thine THC63LVD1024 text binding to YAML. > > > > Signed-off-by: Laurent Pinchart > > --- > > .../display/bridge/thine,thc63lvd1024.txt | 66 ---------- > > .../display/bridge/thine,thc63lvd1024.yaml | 121 ++++++++++++++++++ > > 2 files changed, 121 insertions(+), 66 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > deleted file mode 100644 > > index d17d1e5820d7..000000000000 > > --- a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > +++ /dev/null > > @@ -1,66 +0,0 @@ > > -Thine Electronics THC63LVD1024 LVDS decoder > > -------------------------------------------- > > - > > -The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams > > -to parallel data outputs. The chip supports single/dual input/output modes, > > -handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. > > - > > -Single or dual operation mode, output data mapping and DDR output modes are > > -configured through input signals and the chip does not expose any control bus. > > - > > -Required properties: > > -- compatible: Shall be "thine,thc63lvd1024" > > -- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > > - PPL and digital circuitry > > - > > -Optional properties: > > -- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > > -- oe-gpios: Output enable GPIO signal, pin name "OE". Active high > > - > > -The THC63LVD1024 video port connections are modeled according > > -to OF graph bindings specified by Documentation/devicetree/bindings/graph.txt > > - > > -Required video port nodes: > > -- port@0: First LVDS input port > > -- port@2: First digital CMOS/TTL parallel output > > - > > -Optional video port nodes: > > -- port@1: Second LVDS input port > > -- port@3: Second digital CMOS/TTL parallel output > > - > > -The device can operate in single-link mode or dual-link mode. In single-link > > -mode, all pixels are received on port@0, and port@1 shall not contain any > > -endpoint. In dual-link mode, even-numbered pixels are received on port@0 and > > -odd-numbered pixels on port@1, and both port@0 and port@1 shall contain > > -endpoints. > > - > > -Example: > > --------- > > - > > - thc63lvd1024: lvds-decoder { > > - compatible = "thine,thc63lvd1024"; > > - > > - vcc-supply = <®_lvds_vcc>; > > - powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > > - > > - ports { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - port@0 { > > - reg = <0>; > > - > > - lvds_dec_in_0: endpoint { > > - remote-endpoint = <&lvds_out>; > > - }; > > - }; > > - > > - port@2{ > > - reg = <2>; > > - > > - lvds_dec_out_2: endpoint { > > - remote-endpoint = <&adv7511_in>; > > - }; > > - }; > > - }; > > - }; > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.yaml b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.yaml > > new file mode 100644 > > index 000000000000..469ac4a34273 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.yaml > > @@ -0,0 +1,121 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/thine,thc63lvd1024.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Thine Electronics THC63LVD1024 LVDS Decoder > > + > > +maintainers: > > + - Jacopo Mondi > > Ack > > > + - Laurent Pinchart > > + > > +description: | > > + The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS > > + streams to parallel data outputs. The chip supports single/dual input/output > > + modes, handling up to two LVDS input streams and up to two digital CMOS/TTL > > + outputs. > > + > > + Single or dual operation mode, output data mapping and DDR output modes are > > + configured through input signals and the chip does not expose any control > > + bus. > > + > > +properties: > > + compatible: > > + const: thine,thc63lvd1024 > > + > > + ports: > > + type: object > > + description: | > > + This device has four video ports. Their connections are modeled using the > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > + > > + The device can operate in single-link mode or dual-link mode. In > > + single-link mode, all pixels are received on port@0, and port@1 shall not > > + contain any endpoint. In dual-link mode, even-numbered pixels are > > + received on port@0 and odd-numbered pixels on port@1, and both port@0 and > > + port@1 shall contain endpoints. > > I wonder why we have documented only single/dual input mode and not > single/dual output mode too. The driver only supports single input and > single output, but this might be a good occasion to document the > output port mapping as well. > > How about > > The device can operate in single or dual input and output modes. > > When operating in single input mode, all pixels are received on > port@0, and port@1 shall not contain any endpoint. In dual input > mode, even-numbered pixels are received on port@0 and > odd-numbered pixels on port@1, and both port@0 and port@1 shall > contain endpoints. > > When operating in single output mode all pixels are output from > the first CMOS/TTL port and port@3 shall not contain any > endpoint. In dual output mode pixels are output from both > CMOS/TTL ports and both port@2 and port@3 shall contain > endpoints. This is a good idea, but I'll split it to a separate patch as it makes sense to review it independently of the conversion. > With or without this, as the new bindings are not worse than what they > where already: > > Reviewed-by: Jacopo Mondi > > > + > > + properties: > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + port@0: > > + type: object > > + description: First LVDS input port > > + > > + port@1: > > + type: object > > + description: Second LVDS input port > > + > > + port@2: > > + type: object > > + description: First digital CMOS/TTL parallel output > > + > > + port@3: > > + type: object > > + description: Second digital CMOS/TTL parallel output > > + > > + required: > > + - port@0 > > + - port@2 > > + > > + additionalProperties: false > > + > > + oe-gpios: > > + maxItems: 1 > > + description: Output enable GPIO signal, pin name "OE", active high. > > + > > + powerdown-gpios: > > + maxItems: 1 > > + description: Power down GPIO signal, pin name "/PDWN", active low. > > + > > + vcc-supply: > > + maxItems: 1 > > + description: > > + Power supply for the TTL output, TTL CLOCKOUT signal, LVDS input, PLL and > > + digital circuitry. > > + > > +required: > > + - compatible > > + - ports > > + - vcc-supply > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + lvds-decoder { > > + compatible = "thine,thc63lvd1024"; > > + > > + vcc-supply = <®_lvds_vcc>; > > + powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + lvds_dec_in_0: endpoint { > > + remote-endpoint = <&lvds_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + > > + lvds_dec_out_2: endpoint { > > + remote-endpoint = <&adv7511_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel