From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76122C2BABC for ; Tue, 7 Apr 2020 08:09:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D7ED206F7 for ; Tue, 7 Apr 2020 08:09:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="XsaM3b0z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MaP+HVk2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D7ED206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC83D6E5BF; Tue, 7 Apr 2020 08:09:35 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E0E66E44D for ; Mon, 6 Apr 2020 17:05:05 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A5A695C00D6; Mon, 6 Apr 2020 13:05:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 06 Apr 2020 13:05:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=TdE1HrDFz4yrNizninaJxR7gmC9 gTaFncKtkMVs1KSQ=; b=XsaM3b0zdSFYXhUE/TA/OyiGxuQFi2MoVpLAbePvEYJ IDpuT7aWRj0JPSDWcRRfs/wOvwy5FmN00qajZpiIPn6Z92vzUHbETQHyOSFbv1Hx ljy2IlOw6BiTPNZfN/iaJnCpCoDuAQFG3sR7f0p+dOws1R+LCrXaun53l0uUzhKy hs4kIv3Kncm9erQdBh6IaiFAuH6hOIlzrfDX4KLE4+0Sum0V/V/ealwfl0MWxIrU 914LaP5zC363JAE1Q3NkDLN6WFvsF1WqhqVQ+U8WgxymUImml3W/aEFCtJbNbYf8 pwfFcU0MApl5xl59nhnFmhAfpqfgoHHS4VhG/iIQUHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TdE1Hr DFz4yrNizninaJxR7gmC9gTaFncKtkMVs1KSQ=; b=MaP+HVk2tQR18gxuXhl4Rv ioQSs6EqEOI5WXmwPiy3seNpxm8bxZXHxy8L1YscTlivu8HGttPohrDaxDc7jufN Ga3gr15u3Y6Ar7TW9yr5rQLOVzTDZRziink+62rJgJsntxQV0lkmiELqw++mNQ8v gJqcYKenAO8Tro00L21gwltgj+I4x9s/2g9N/Ih2404xl04AnMlhP+5hpmryI2Z1 YUj2pcvmau5oZe2b7Ys49KMW2R2755rokLKEHNGjuXk1WJhu3hK7GL21FQ5E2LAM RowS0csLFfIOm3P8q1WnCWvuHhdodD++CCtjGbW2FFpObPuWKyKGbNaHFyi7k+FQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecukfhppeeltd drkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id E9EBF328005E; Mon, 6 Apr 2020 13:05:00 -0400 (EDT) Date: Mon, 6 Apr 2020 19:04:59 +0200 From: Maxime Ripard To: Laurent Pinchart Subject: Re: [PATCH/RFC 2/6] dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML Message-ID: <20200406170459.wwfxtsuvjuhlcyoe@gilmour.lan> References: <20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com> <20200405233935.27599-3-laurent.pinchart+renesas@ideasonboard.com> <20200406075705.a67tjx7jamdvqpl3@gilmour.lan> <20200406112856.GE4757@pendragon.ideasonboard.com> <20200406113247.GF4757@pendragon.ideasonboard.com> MIME-Version: 1.0 In-Reply-To: <20200406113247.GF4757@pendragon.ideasonboard.com> X-Mailman-Approved-At: Tue, 07 Apr 2020 08:09:32 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Laurent Pinchart , Sandy Huang , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Mark Yao Content-Type: multipart/mixed; boundary="===============0624305144==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0624305144== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jjly33wr43te7soq" Content-Disposition: inline --jjly33wr43te7soq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2020 at 02:32:47PM +0300, Laurent Pinchart wrote: > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: iahb > > > > + - const: isfr > > > > + > > > > + interrupts: true > > > > + > > > > + ports: > > > > + type: object > > > > + description: | > > > > + This device has three video ports. Their connections are modelled using the > > > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > > > + Each port shall have a single endpoint. > > > > + > > > > + properties: > > > > + '#address-cells': > > > > + const: 1 > > > > + > > > > + '#size-cells': > > > > + const: 0 > > > > + > > > > + port@0: > > > > + type: object > > > > + description: Parallel RGB input port > > > > + > > > > + port@1: > > > > + type: object > > > > + description: HDMI output port > > > > + > > > > + port@2: > > > > + type: object > > > > + description: Sound input port > > > > + > > > > + required: > > > > + - port@0 > > > > + - port@1 > > > > + - port@2 > > > > + > > > > + additionalProperties: false > > Would it also make sense to use unevaluatedProperties here, and drop > #address-cells and #size-cells above as they're already evaluated in > synopsys,dw-hdmi.yaml ? Yup :) > > > > + > > > > + power-domains: > > > > + maxItems: 1 > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - clocks > > > > + - clock-names > > > > + - interrupts > > > > + - ports > > > > + > > > > +additionalProperties: false > > > > > > In the case where you have some kind of generic schema and then a more > > > specific one like you have here, unevaluatedProperties make more sense > > > that additionalProperties. > > > > > > additionalProperties checks that there are no extra properties on the > > > current schema, which is a problem here since you have to duplicate > > > the entire list of properties found in the generic schema, while > > > unevaluatedProperties checks that there are no extra properties in the > > > entire set of all schemas that apply to this node. > > > > > > This way, you can just put what is different from the generic schema, > > > and you don't have to keep it in sync. > > > > > > It's a feature that has been added in the spec of the schemas that > > > went on right after the one we support in the tools, so for now the > > > kernel meta-schemas only allows that property to be there (just like > > > deprecated) but won't do anything. > > > > > > This should be fixed quite soon however, the library we depend on > > > has started to work on that spec apparently. > > > > Should I postpone this series until support for unevaluatedProperties is > > available, to be able to test this ? > > Also, to make sure I understand this correctly, does it mean I can drop > "reg: true" and "interrupts: true" ? Ditto :) Maxime --jjly33wr43te7soq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXothOwAKCRDj7w1vZxhR xfGKAP4s6mB0LoyQBJnjI1zv86BbMfARna9rT67dl0wWydot3gD/btht1OMEjHzO c5B0gD7fVvyOgVGCkCLDa3NAQnb/tw8= =uhCv -----END PGP SIGNATURE----- --jjly33wr43te7soq-- --===============0624305144== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0624305144==--