From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oliver Graute <oliver.graute@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
gregkh@linuxfoundation.org,
Oliver Graute <oliver.graute@kococonnector.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display
Date: Thu, 9 Apr 2020 13:22:03 +0300 [thread overview]
Message-ID: <20200409102013.GP2001@kadam> (raw)
In-Reply-To: <1586424337-26602-1-git-send-email-oliver.graute@gmail.com>
On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote:
> From: Oliver Graute <oliver.graute@kococonnector.com>
>
> Set Gamma Values and Register Values for the HSD20_IPS
>
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> ---
> drivers/staging/fbtft/fb_st7789v.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
> index 84c5af2dc9a0..b0aa96b703a8 100644
> --- a/drivers/staging/fbtft/fb_st7789v.c
> +++ b/drivers/staging/fbtft/fb_st7789v.c
> @@ -17,8 +17,8 @@
> #define DRVNAME "fb_st7789v"
>
> #define DEFAULT_GAMMA \
> - "70 2C 2E 15 10 09 48 33 53 0B 19 18 20 25\n" \
> - "70 2C 2E 15 10 09 48 33 53 0B 19 18 20 25"
> + "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \
> + "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33"
How do you know this won't break someone else's setup?
>
> /**
> * enum st7789v_command - ST7789V display controller commands
> @@ -83,13 +83,13 @@ static int init_display(struct fbtft_par *par)
> /* set pixel format to RGB-565 */
> write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_16BIT);
>
> - write_reg(par, PORCTRL, 0x08, 0x08, 0x00, 0x22, 0x22);
> + write_reg(par, PORCTRL, 0x05, 0x05, 0x00, 0x33, 0x33);
Without knowing anything at all about this driver, it feels like this
should be:
if (new_hardware)
write_reg(par, PORCTRL, 0x05, 0x05, 0x00, 0x33, 0x33);
else
write_reg(par, PORCTRL, 0x08, 0x08, 0x00, 0x22, 0x22);
Same comment for the rest of the patch.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-09 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:25 [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display Oliver Graute
2020-04-09 10:22 ` Dan Carpenter [this message]
2020-04-27 8:36 ` Oliver Graute
2020-04-27 9:33 ` Dan Carpenter
2020-04-27 12:36 ` Oliver Graute
2020-04-28 18:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409102013.GP2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.graute@gmail.com \
--cc=oliver.graute@kococonnector.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).