From: Sam Ravnborg <sam@ravnborg.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Tang Bin <tangbin@cmss.chinamobile.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()
Date: Fri, 10 Apr 2020 14:14:06 +0200 [thread overview]
Message-ID: <20200410121406.GA31761@ravnborg.org> (raw)
In-Reply-To: <235b500a-0e5e-9ca3-4be5-9026c7d9f87f@web.de>
Hi Markus.
On Fri, Apr 10, 2020 at 12:56:25PM +0200, Markus Elfring wrote:
> > The right way to check for errors is to check if the return value is
> > less than 0.
>
> Thanks for your constructive feedback.
>
> I was unsure if I noticed another programming mistake.
>
>
> > Could you please audit all uses of platform_get_irq() in drivers/gpu/
>
> I found 20 source files from the software “Linux next-20200408”
> which seem to contain similar update candidates.
> Would you like to clarify any extensions for improved applications
> of scripts with the semantic patch language (Coccinelle software)
> for corresponding analysis and transformation purposes?
Please just send a series of patches, one for each driver.
Each changelog needs to explain the rationale behind the change.
Look at how this is often done.
As for coccinelle - I cannot help you.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-10 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 13:05 drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe() Markus Elfring
2020-04-10 10:18 ` Sam Ravnborg
2020-04-10 10:56 ` Markus Elfring
2020-04-10 12:14 ` Sam Ravnborg [this message]
2020-04-10 12:25 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410121406.GA31761@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Markus.Elfring@web.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).