From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Rob Clark <robdclark@chromium.org>,
Sasha Levin <sashal@kernel.org>, Pavel Machek <pavel@denx.de>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.5 084/121] drm/msm: fix leaks if initialization fails
Date: Sat, 11 Apr 2020 19:06:29 -0400 [thread overview]
Message-ID: <20200411230706.23855-84-sashal@kernel.org> (raw)
In-Reply-To: <20200411230706.23855-1-sashal@kernel.org>
From: Pavel Machek <pavel@denx.de>
[ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ]
We should free resources in unlikely case of allocation failure.
Signed-off-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/msm/msm_drv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index b73fbb65e14b2..68785ee02e97c 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -444,8 +444,10 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
if (!dev->dma_parms) {
dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
GFP_KERNEL);
- if (!dev->dma_parms)
- return -ENOMEM;
+ if (!dev->dma_parms) {
+ ret = -ENOMEM;
+ goto err_msm_uninit;
+ }
}
dma_set_max_seg_size(dev, DMA_BIT_MASK(32));
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-11 23:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200411230706.23855-1-sashal@kernel.org>
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 013/121] drm/amd/display: Explicitly disable triplebuffer flips Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 026/121] drm/tegra: dc: Release PM and RGB output when client's registration fails Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 028/121] drm/amd/display: Stop if retimer is not available Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 030/121] drm/amd/display: writing stereo polarity register if swapped Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 033/121] drm/amd/display: Fix default logger mask definition Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 037/121] drm/amd/display: Only round InfoFrame refresh rates Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 039/121] drm/panel: simple: fix osd070t1718_19ts sync drive edge Sasha Levin
2020-04-11 23:05 ` [PATCH AUTOSEL 5.5 048/121] drm/sun4i: dsi: Use NULL to signify "no panel" Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 056/121] drm/omap: fix possible object reference leak Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 059/121] drm/stm: ltdc: check crtc state before enabling LIE Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 060/121] fbdev: potential information leak in do_fb_ioctl() Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 061/121] drm/crc: Actually allow to change the crc source Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 062/121] drm/amdgpu: fix parentheses in amdgpu_vm_update_ptes Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 063/121] drm/amd/display: dc_get_vmid_use_vector() crashes when get called Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 069/121] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 070/121] drm/amd/display: System crashes when add_ptb_to_table() gets called Sasha Levin
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 071/121] drm/omap: dss: Cleanup DSS ports on initialisation failure Sasha Levin
2020-04-11 23:06 ` Sasha Levin [this message]
2020-04-11 23:06 ` [PATCH AUTOSEL 5.5 085/121] drm/msm/a5xx: Always set an OPP supported hardware value Sasha Levin
2020-04-11 23:07 ` [PATCH AUTOSEL 5.5 121/121] PCI: Use ioremap(), not phys_to_virt() for platform ROM Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411230706.23855-84-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=robdclark@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).