From: Rob Herring <robh@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 06/36] dt-bindings: display: convert boe, himax8279d to DT Schema
Date: Tue, 14 Apr 2020 13:25:49 -0500 [thread overview]
Message-ID: <20200414182549.GA11086@bogus> (raw)
In-Reply-To: <20200408195109.32692-7-sam@ravnborg.org>
On Wed, Apr 08, 2020 at 09:50:39PM +0200, Sam Ravnborg wrote:
> v2:
> - Fix entry in MAINTAINERS
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
> .../bindings/display/panel/boe,himax8279d.txt | 24 --------
> .../display/panel/boe,himax8279d.yaml | 59 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 60 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> create mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> deleted file mode 100644
> index 3caea2172b1b..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Boe Himax8279d 1200x1920 TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10p"
> -- reg: DSI virtual channel of the peripheral
> -- enable-gpios: panel enable gpio
> -- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply voltage
> -- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> - &mipi_dsi {
> - panel {
> - compatible = "boe,himax8279d8p", "boe,himax8279d10p";
> - reg = <0>;
> - backlight = <&backlight>;
> - enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> - pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> - pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
> new file mode 100644
> index 000000000000..e42b6a8ae176
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/boe,himax8279d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Boe Himax8279d 1200x1920 TFT LCD panel
> +
> +maintainers:
> + - Jerry Han <jerry.han.hq@gmail.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: boe,himax8279d8p
> + - const: boe,himax8279d10p
> +
> + backlight: true
> + enable-gpios: true
> + reg: true
> +
> + pp33-gpios:
> + maxItems: 1
> + description: GPIO for the 3.3v pin that provides the supply voltage
> +
> + pp18-gpios:
> + maxItems: 1
> + description: GPIO for the 1.8v pin that provides the supply voltage
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - pp33-gpios
> + - pp18-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel {
panel@0
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
Double check the others. I won't repeat myself.
> + compatible = "boe,himax8279d8p", "boe,himax8279d10p";
> + reg = <0>;
> + backlight = <&backlight>;
> + enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> + pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> + pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b99fa16ba08..dba84e7726b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5255,7 +5255,7 @@ DRM DRIVER FOR BOE HIMAX8279D PANELS
> M: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> S: Maintained
> F: drivers/gpu/drm/panel/panel-boe-himax8279d.c
> -F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +F: Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml
>
> DRM DRIVER FOR FARADAY TVE200 TV ENCODER
> M: Linus Walleij <linus.walleij@linaro.org>
> --
> 2.20.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-14 18:25 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 19:50 [PATCH v2 0/36] dt-bindings: display: convert remaning panel bindings to DT Schema Sam Ravnborg
2020-04-08 19:50 ` [PATCH v2 01/36] dt-bindings: display: allow port and ports in panel-lvds Sam Ravnborg
2020-04-09 16:11 ` Rob Herring
2020-04-12 20:04 ` Sam Ravnborg
2020-04-09 17:03 ` Lad, Prabhakar
2020-04-08 19:50 ` [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller Sam Ravnborg
2020-04-14 18:21 ` Rob Herring
2020-04-16 11:26 ` Linus Walleij
2020-04-16 11:50 ` Sam Ravnborg
2020-04-16 15:00 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 03/36] dt-bindings: display: add te-gpios to panel-common Sam Ravnborg
2020-04-14 19:03 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 04/36] dt-bindings: display: convert samsung, s6e63m0 to DT Schema Sam Ravnborg
2020-04-14 18:22 ` [PATCH v2 04/36] dt-bindings: display: convert samsung,s6e63m0 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 05/36] dt-bindings: display: convert arm, versatile-tft-panel " Sam Ravnborg
2020-04-14 18:23 ` [PATCH v2 05/36] dt-bindings: display: convert arm,versatile-tft-panel " Rob Herring
2020-04-16 11:27 ` Linus Walleij
2020-04-08 19:50 ` [PATCH v2 06/36] dt-bindings: display: convert boe, himax8279d " Sam Ravnborg
2020-04-14 18:25 ` Rob Herring [this message]
2020-04-08 19:50 ` [PATCH v2 07/36] dt-bindings: display: convert ilitek, ili9322 " Sam Ravnborg
2020-04-14 18:26 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 08/36] dt-bindings: display: convert ilitek, ili9881c " Sam Ravnborg
2020-04-14 18:27 ` [PATCH v2 08/36] dt-bindings: display: convert ilitek,ili9881c " Rob Herring
2020-04-08 19:50 ` [PATCH v2 09/36] dt-bindings: display: convert innolux, p079zca " Sam Ravnborg
2020-04-14 18:29 ` [PATCH v2 09/36] dt-bindings: display: convert innolux,p079zca " Rob Herring
2020-04-08 19:50 ` [PATCH v2 10/36] dt-bindings: display: convert innolux, p097pfg " Sam Ravnborg
2020-04-14 18:30 ` [PATCH v2 10/36] dt-bindings: display: convert innolux,p097pfg " Rob Herring
2020-04-08 19:50 ` [PATCH v2 11/36] dt-bindings: display: convert innolux, p120zdg-bf1 " Sam Ravnborg
2020-04-14 18:30 ` [PATCH v2 11/36] dt-bindings: display: convert innolux,p120zdg-bf1 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 12/36] dt-bindings: display: convert jdi, lt070me05000 " Sam Ravnborg
2020-04-14 18:31 ` [PATCH v2 12/36] dt-bindings: display: convert jdi,lt070me05000 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 13/36] dt-bindings: display: convert kingdisplay, kd035g6-54nt " Sam Ravnborg
2020-04-14 18:33 ` [PATCH v2 13/36] dt-bindings: display: convert kingdisplay,kd035g6-54nt " Rob Herring
2020-04-08 19:50 ` [PATCH v2 14/36] dt-bindings: display: convert kingdisplay, kd097d04 " Sam Ravnborg
2020-04-14 18:33 ` [PATCH v2 14/36] dt-bindings: display: convert kingdisplay,kd097d04 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 15/36] dt-bindings: display: convert simple lg panels " Sam Ravnborg
2020-04-14 18:34 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 16/36] dt-bindings: display: convert lg, lg4573 " Sam Ravnborg
2020-04-14 18:34 ` [PATCH v2 16/36] dt-bindings: display: convert lg,lg4573 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 17/36] dt-bindings: display: convert osddisplays, osd101t2587-53ts " Sam Ravnborg
2020-04-14 18:35 ` [PATCH v2 17/36] dt-bindings: display: convert osddisplays,osd101t2587-53ts " Rob Herring
2020-04-08 19:50 ` [PATCH v2 18/36] dt-bindings: display: convert raydium, rm67191 " Sam Ravnborg
2020-04-14 18:36 ` [PATCH v2 18/36] dt-bindings: display: convert raydium,rm67191 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 19/36] dt-bindings: display: convert rocktech, jh057n00900 " Sam Ravnborg
2020-04-14 18:37 ` [PATCH v2 19/36] dt-bindings: display: convert rocktech,jh057n00900 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 20/36] dt-bindings: display: convert samsung AMOLED " Sam Ravnborg
2020-04-14 18:38 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 21/36] dt-bindings: display: convert samsung, s6d16d0 " Sam Ravnborg
2020-04-14 18:39 ` [PATCH v2 21/36] dt-bindings: display: convert samsung,s6d16d0 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 22/36] dt-bindings: display: convert samsung, ld9040 " Sam Ravnborg
2020-04-14 18:40 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 23/36] dt-bindings: display: convert samsung, s6e8aa0 " Sam Ravnborg
2020-04-14 18:47 ` [PATCH v2 23/36] dt-bindings: display: convert samsung,s6e8aa0 " Rob Herring
2020-04-08 19:50 ` [PATCH v2 24/36] dt-bindings: display: convert toppoly panels " Sam Ravnborg
[not found] ` <981A14FA-AFB0-47B6-9EEF-E1C09828976F@goldelico.com>
2020-04-14 18:50 ` Rob Herring
2020-04-14 18:51 ` Rob Herring
2020-04-08 19:50 ` [PATCH v2 25/36] dt-bindings: display: convert startek, startek-kd050c " Sam Ravnborg
2020-04-14 18:51 ` [PATCH v2 25/36] dt-bindings: display: convert startek,startek-kd050c " Rob Herring
2020-04-08 19:50 ` [PATCH v2 26/36] dt-bindings: display: convert sony, acx565akm " Sam Ravnborg
2020-04-14 18:52 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 27/36] dt-bindings: display: convert sitronix, st7789v " Sam Ravnborg
2020-04-14 18:52 ` [PATCH v2 27/36] dt-bindings: display: convert sitronix,st7789v " Rob Herring
2020-04-08 19:51 ` [PATCH v2 28/36] dt-bindings: display: drop unused simple-panel.txt Sam Ravnborg
2020-04-14 18:53 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 29/36] dt-bindings: display: convert sharp, ls043t1le01 to DT Schema Sam Ravnborg
2020-04-14 18:54 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 30/36] dt-bindings: display: convert sharp, lq101r1sx01 " Sam Ravnborg
2020-04-14 18:57 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 31/36] dt-bindings: display: convert sharp, ls037v7dw01 " Sam Ravnborg
2020-04-14 18:58 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 32/36] dt-bindings: display: convert sharp, lq150x1lg11 " Sam Ravnborg
2020-04-14 18:59 ` Rob Herring
2020-04-08 19:51 ` [PATCH v2 33/36] dt-bindings: display: convert seiko, 43wvf1g " Sam Ravnborg
2020-04-14 18:59 ` [PATCH v2 33/36] dt-bindings: display: convert seiko,43wvf1g " Rob Herring
2020-04-08 19:51 ` [PATCH v2 34/36] dt-bindings: display: convert lgphilips, lb035q02 " Sam Ravnborg
2020-04-14 19:00 ` [PATCH v2 34/36] dt-bindings: display: convert lgphilips,lb035q02 " Rob Herring
2020-04-08 19:51 ` [PATCH v2 35/36] dt-bindings: display: convert olimex, lcd-olinuxino " Sam Ravnborg
2020-04-14 19:01 ` [PATCH v2 35/36] dt-bindings: display: convert olimex,lcd-olinuxino " Rob Herring
2020-04-08 19:51 ` [PATCH v2 36/36] dt-bindings: display: move DSI panels to panel-simple-dsi Sam Ravnborg
2020-04-14 19:02 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414182549.GA11086@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanxu5@huaqin.corp-partner.google.com \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).