From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E57C2BA19 for ; Wed, 15 Apr 2020 13:44:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10E022074F for ; Wed, 15 Apr 2020 13:44:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10E022074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93D3E6E936; Wed, 15 Apr 2020 13:44:21 +0000 (UTC) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B24936E936 for ; Wed, 15 Apr 2020 13:44:20 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id f12so1118304edn.12 for ; Wed, 15 Apr 2020 06:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ue1uYbSCM3f3qpA8DP0y7k1ImrV8BLgfQdpHr8wCsNY=; b=t1tHUxzTiQgXENqpRPkhu4r7D53edZ0m+YyDfE4zZm77mBrAeD+AJk/qDcvaXqE7sj nAyIMVaWsW9+exn0uRkwmZYyYY2s/1D032EXWTzANychHZBBwmhrSGPXpqM77rUzDgDy EFUsCBcmM1V77AuJCMlTC6eu1s2KbqZ1OmdXh/9MmaHYF2/vvqCkqQvnwkzKyhQAh5K/ TngNW9975u9CEFjfFLzT2UaRr+IFp4oEB9q2S5jy2djzxqtXYd9LpsmfG0Du+ArwxHAG XS0tJUsmXrraheqIzm1CGO0dFMuGuXgBtJPARHpM2ymp/nBgfUTsXMn0MZ3srnJ6iVLO 2I5w== X-Gm-Message-State: AGi0PuaOMTkDVzn6sI6awQfAIyyt+wvdaIJqb51QGHlousk9odKMORau NkFP57IG4NZe5ygN7L+XksM= X-Google-Smtp-Source: APiQypKNYzTDTcjJXJkyJ1tW3CmeNRTTMuezBm45FxKlxDAUOBaCIldgd2OqLmdaCh5e2z6JTgFDtA== X-Received: by 2002:a17:907:118b:: with SMTP id uz11mr4894575ejb.89.1586958259236; Wed, 15 Apr 2020 06:44:19 -0700 (PDT) Received: from kozik-lap ([194.230.155.125]) by smtp.googlemail.com with ESMTPSA id bs8sm2626297ejb.92.2020.04.15.06.44.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 06:44:18 -0700 (PDT) Date: Wed, 15 Apr 2020 15:44:15 +0200 From: Krzysztof Kozlowski To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node Message-ID: <20200415134415.GA21120@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 02:50:31PM +0200, H. Nikolaus Schaller wrote: > > > Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > >> > >> From: Jonathan Bakker > >> > >> to add support for SGX540 GPU. > > > > Do not continue the subject in commit msg like it is one sentence. > > These are two separate sentences, so commit msg starts with capital > > letter and it is sentence by itself. > > > >> Signed-off-by: Jonathan Bakker > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > >> index 2ad642f51fd9..e7fc709c0cca 100644 > >> --- a/arch/arm/boot/dts/s5pv210.dtsi > >> +++ b/arch/arm/boot/dts/s5pv210.dtsi > >> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > >> #interrupt-cells = <1>; > >> }; > >> > >> + g3d: g3d@f3000000 { > >> + compatible = "samsung,s5pv210-sgx540-120"; > >> + reg = <0xf3000000 0x10000>; > >> + interrupt-parent = <&vic2>; > >> + interrupts = <10>; > >> + clock-names = "sclk"; > >> + clocks = <&clocks CLK_G3D>; > > > > Not part of bindings, please remove or add to the bindings. > > Well, the bindings should describe what is common for all SoC > and they are quite different in what they need in addition. > > Thererfore we have no "additionalProperties: false" in the > bindings [PATCH v6 01/12]. If these properties are needed for Exynos-specific implementation, they should be in the bindings. If they are not needed, they should not be here. Take a look at midgard bindings for example. This is a nice starting point for these here. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel