From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F988C2BB85 for ; Wed, 15 Apr 2020 17:48:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 494D92078B for ; Wed, 15 Apr 2020 17:48:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OOw0p460" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 494D92078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC0DD6EA4C; Wed, 15 Apr 2020 17:48:53 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0B2C6EA4B for ; Wed, 15 Apr 2020 17:48:52 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E51802D1; Wed, 15 Apr 2020 19:48:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586972931; bh=xIRX6G8MPMzVE7tjXbBjuWGgq9zLKM2OkNZ09OL5Xm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OOw0p460Ce9jFAY15cEC3t0BdFA6nUpJbt4v5rywt+Hpvgd153mZXF9SWYHCq0hRo kYlb7TnHmA6nRO8miWF9zAKO0GbmxYfvUMmHHiHgeVMfYXj3Xs05hPBEchdCb734f8 BVd6D9cXGjnnqoPSvN9fRLtpUzwL6hs7azzCs728= Date: Wed, 15 Apr 2020 20:48:06 +0300 From: Laurent Pinchart To: Daniel Vetter Subject: Re: [PATCH] drm/bridge: Move mhl.h into driver directory Message-ID: <20200415174806.GL4758@pendragon.ideasonboard.com> References: <20200415173833.312706-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200415173833.312706-1-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Jernej Skrabec , Neil Armstrong , Greg Kroah-Hartman , Jonas Karlman , Alexey Brodkin , DRI Development , "Gustavo A. R. Silva" , Andrzej Hajda , Daniel Vetter , Thomas Gleixner , Sam Ravnborg , Allison Randal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, Thank you for the patch. On Wed, Apr 15, 2020 at 07:38:33PM +0200, Daniel Vetter wrote: > include/drm/bridge is a bit a mistake, drivers are supposed to find > their bridges using one of the standard of_* functions the drm_bridge > core provides. I'm confused, I don't really see how that's related to mhl.h. The header defines constants and structures related to the MHL (Mobile High-Definition Link) protocol, which is an industry standard. If you want to move it out of include/drm/bridge/ to eventually remove that directory, I think it should be renamted to include/drm/drm_mhl.h. > dw-hdmi and analogix-dp are the only, historically > grown exception that we haven't managed to get rid of yet. The reason why we have shared headers for those is because they're IP cores integrated with different glue layers in different SoCs. There's one driver for the IP core itself, and SoC-specific glue drivers that need to provide the IP core drivers with data and callbacks, defined in shared headers. Granted, there's also data in those headers that are only internal to the IP core drivers, and that should be moved out, but for the interface header, include/drm/bridge/ doesn't seem to be a bad location to me. > Make sure that at least no new ones grow by moving hardware header > files into the correct driver directory. > > Signed-off-by: Daniel Vetter > Cc: Alexey Brodkin > Cc: Sam Ravnborg > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Daniel Vetter > Cc: Kate Stewart > Cc: Thomas Gleixner > Cc: Allison Randal > Cc: Greg Kroah-Hartman > Cc: "Gustavo A. R. Silva" > --- > {include => drivers/gpu}/drm/bridge/mhl.h | 0 > drivers/gpu/drm/bridge/sii9234.c | 3 ++- > drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > rename {include => drivers/gpu}/drm/bridge/mhl.h (100%) > > diff --git a/include/drm/bridge/mhl.h b/drivers/gpu/drm/bridge/mhl.h > similarity index 100% > rename from include/drm/bridge/mhl.h > rename to drivers/gpu/drm/bridge/mhl.h > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > index b1258f0ed205..4c862c3af038 100644 > --- a/drivers/gpu/drm/bridge/sii9234.c > +++ b/drivers/gpu/drm/bridge/sii9234.c > @@ -12,7 +12,6 @@ > * Shankar Bandal > * Dharam Kumar > */ > -#include > #include > #include > #include > @@ -29,6 +28,8 @@ > #include > #include > > +#include "mhl.h" > + > #define CBUS_DEVCAP_OFFSET 0x80 > > #define SII9234_MHL_VERSION 0x11 > diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c > index 92acd336aa89..017dbb67404e 100644 > --- a/drivers/gpu/drm/bridge/sil-sii8620.c > +++ b/drivers/gpu/drm/bridge/sil-sii8620.c > @@ -8,7 +8,6 @@ > > #include > > -#include > #include > #include > #include > @@ -31,6 +30,7 @@ > > #include > > +#include "mhl.h" > #include "sil-sii8620.h" > > #define SII8620_BURST_BUF_LEN 288 -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel