dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type
@ 2020-04-17 11:40 Tomi Valkeinen
  2020-04-17 13:00 ` Tomi Valkeinen
  2020-05-04 19:46 ` Sam Ravnborg
  0 siblings, 2 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2020-04-17 11:40 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, dri-devel, Laurent Pinchart; +Cc: Tomi Valkeinen

The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
indicated by the current bus_format.

Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
connector_type to LVDS.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ad828eaefe1..bf781e260fe7 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
 		.width = 216,
 		.height = 135,
 	},
-	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g104sn02_mode = {
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type
  2020-04-17 11:40 [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type Tomi Valkeinen
@ 2020-04-17 13:00 ` Tomi Valkeinen
  2020-04-17 13:10   ` Laurent Pinchart
  2020-05-04 19:46 ` Sam Ravnborg
  1 sibling, 1 reply; 4+ messages in thread
From: Tomi Valkeinen @ 2020-04-17 13:00 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, dri-devel, Laurent Pinchart, Alex Gonzalez

(Adding Alex to the thread)

On 17/04/2020 14:40, Tomi Valkeinen wrote:
> The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> indicated by the current bus_format.
> 
> Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> connector_type to LVDS.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..bf781e260fe7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
>   		.width = 216,
>   		.height = 135,
>   	},
> -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   
>   static const struct drm_display_mode auo_g104sn02_mode = {
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type
  2020-04-17 13:00 ` Tomi Valkeinen
@ 2020-04-17 13:10   ` Laurent Pinchart
  0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2020-04-17 13:10 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: Alex Gonzalez, Thierry Reding, Sam Ravnborg, dri-devel

Hi Tomi,

Thank you for the patch.

On Fri, Apr 17, 2020 at 04:00:34PM +0300, Tomi Valkeinen wrote:
> (Adding Alex to the thread)
> 
> On 17/04/2020 14:40, Tomi Valkeinen wrote:
> > The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> > indicated by the current bus_format.
> > 
> > Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> > connector_type to LVDS.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

I'll trust you on the format,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >   drivers/gpu/drm/panel/panel-simple.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..bf781e260fe7 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
> >   		.width = 216,
> >   		.height = 135,
> >   	},
> > -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> >   };
> >   
> >   static const struct drm_display_mode auo_g104sn02_mode = {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type
  2020-04-17 11:40 [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type Tomi Valkeinen
  2020-04-17 13:00 ` Tomi Valkeinen
@ 2020-05-04 19:46 ` Sam Ravnborg
  1 sibling, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-05-04 19:46 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: Thierry Reding, Laurent Pinchart, dri-devel

Hi Tomi.

On Fri, Apr 17, 2020 at 02:40:43PM +0300, Tomi Valkeinen wrote:
> The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> indicated by the current bus_format.
> 
> Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> connector_type to LVDS.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Updated subject a little and applied.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..bf781e260fe7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
>  		.width = 216,
>  		.height = 135,
>  	},
> -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
>  static const struct drm_display_mode auo_g104sn02_mode = {
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-04 19:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 11:40 [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type Tomi Valkeinen
2020-04-17 13:00 ` Tomi Valkeinen
2020-04-17 13:10   ` Laurent Pinchart
2020-05-04 19:46 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).