Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1 next-20200416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next config: sparc64-defconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sparc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): arch/sparc/kernel/sbus.c: In function 'sbus_init': >> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 669 | struct platform_device *op = of_find_device_by_node(dp); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode >> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] cc1: all warnings being treated as errors -- arch/sparc/kernel/pci.c: In function 'of_create_pci_dev': >> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 276 | op = of_find_device_by_node(node); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode >> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 276 | op = of_find_device_by_node(node); | ^ cc1: all warnings being treated as errors -- arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers': >> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 324 | op = of_find_device_by_node(dp); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 324 | op = of_find_device_by_node(dp); | ^ cc1: all warnings being treated as errors -- arch/sparc/kernel/pci_schizo.c: In function 'tomatillo_register_error_handlers': >> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'? [-Werror=implicit-function-declaration] 850 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node); | ^~~~~~~~~~~~~~~~~~~~~~ | bus_find_device_by_fwnode arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers': arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct platform_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] 945 | struct platform_device *op = of_find_device_by_node(pbm->op->dev.of_node); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +669 arch/sparc/kernel/sbus.c 8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664 static int __init sbus_init(void) 576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 { 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666 struct device_node *dp; 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 668 for_each_node_by_name(dp, "sbus") { cd4cd7306a403f arch/sparc/kernel/sbus.c Grant Likely 2010-07-22 @669 struct platform_device *op = of_find_device_by_node(dp); 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 670 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 671 sbus_iommu_init(op); 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 672 of_propagate_archdata(op); 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 673 } 576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 674 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 675 return 0; 576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 676 } 046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 677 :::::: The code at line 669 was first introduced by commit :::::: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to of_device and to_of_device :::::: TO: Grant Likely :::::: CC: Grant Likely --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org