From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B05B6C54FCB for ; Fri, 24 Apr 2020 16:38:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F94C206D7 for ; Fri, 24 Apr 2020 16:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F94C206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D62056EABE; Fri, 24 Apr 2020 16:38:01 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BDC46EABE; Fri, 24 Apr 2020 16:38:00 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 4061820031; Fri, 24 Apr 2020 18:37:58 +0200 (CEST) Date: Fri, 24 Apr 2020 18:37:57 +0200 From: Sam Ravnborg To: Daniel Vetter Subject: Re: [PATCH 37/59] drm/cirrus: Move to drm/tiny Message-ID: <20200424163756.GB3822@ravnborg.org> References: <20200415074034.175360-1-daniel.vetter@ffwll.ch> <20200415074034.175360-38-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200415074034.175360-38-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ULXz4hXy c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=QyXUC8HyAAAA:8 a=20KFwNOVAAAA:8 a=Z4Rwk6OoAAAA:8 a=7gkXJVJtAAAA:8 a=RYJPnzK0AAAA:8 a=e5mUnYsNAAAA:8 a=aR16PxjQAAAA:8 a=SbjN3GQ1GeqvrpwrGE8A:9 a=CjuIK1q_8ugA:10 a=HkZW87K1Qel5hWWM3VKY:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=71IlbOU7e524H-Equz-4:22 a=Vxmtnl_E_bksehYqCbjh:22 a=zbFvvTOBjyH4ze5LlUjX:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , DRI Development , virtualization@lists.linux-foundation.org, Gerd Hoffmann , Dave Airlie , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 09:40:12AM +0200, Daniel Vetter wrote: > Because it is. Huge congrats to everyone who made this kind of > refactoring happen! > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualization@lists.linux-foundation.org Acked-by: Sam Ravnborg > --- > MAINTAINERS | 2 +- > drivers/gpu/drm/Kconfig | 2 -- > drivers/gpu/drm/Makefile | 1 - > drivers/gpu/drm/cirrus/Kconfig | 19 ------------------- > drivers/gpu/drm/cirrus/Makefile | 2 -- > drivers/gpu/drm/tiny/Kconfig | 19 +++++++++++++++++++ > drivers/gpu/drm/tiny/Makefile | 1 + > drivers/gpu/drm/{cirrus => tiny}/cirrus.c | 0 > 8 files changed, 21 insertions(+), 25 deletions(-) > delete mode 100644 drivers/gpu/drm/cirrus/Kconfig > delete mode 100644 drivers/gpu/drm/cirrus/Makefile > rename drivers/gpu/drm/{cirrus => tiny}/cirrus.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7b3255d96d1d..0a5cf105ee37 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5397,7 +5397,7 @@ L: virtualization@lists.linux-foundation.org > S: Obsolete > W: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: drivers/gpu/drm/cirrus/ > +F: drivers/gpu/drm/tiny/cirrus.c > > DRM DRIVER FOR QXL VIRTUAL GPU > M: Dave Airlie > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 43594978958e..4f4e7fa001c1 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -310,8 +310,6 @@ source "drivers/gpu/drm/ast/Kconfig" > > source "drivers/gpu/drm/mgag200/Kconfig" > > -source "drivers/gpu/drm/cirrus/Kconfig" > - > source "drivers/gpu/drm/armada/Kconfig" > > source "drivers/gpu/drm/atmel-hlcdc/Kconfig" > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index f34d08c83485..2c0e5a7e5953 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -74,7 +74,6 @@ obj-$(CONFIG_DRM_I915) += i915/ > obj-$(CONFIG_DRM_MGAG200) += mgag200/ > obj-$(CONFIG_DRM_V3D) += v3d/ > obj-$(CONFIG_DRM_VC4) += vc4/ > -obj-$(CONFIG_DRM_CIRRUS_QEMU) += cirrus/ > obj-$(CONFIG_DRM_SIS) += sis/ > obj-$(CONFIG_DRM_SAVAGE)+= savage/ > obj-$(CONFIG_DRM_VMWGFX)+= vmwgfx/ > diff --git a/drivers/gpu/drm/cirrus/Kconfig b/drivers/gpu/drm/cirrus/Kconfig > deleted file mode 100644 > index c6bbd988b0e5..000000000000 > --- a/drivers/gpu/drm/cirrus/Kconfig > +++ /dev/null > @@ -1,19 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0-only > -config DRM_CIRRUS_QEMU > - tristate "Cirrus driver for QEMU emulated device" > - depends on DRM && PCI && MMU > - select DRM_KMS_HELPER > - select DRM_GEM_SHMEM_HELPER > - help > - This is a KMS driver for emulated cirrus device in qemu. > - It is *NOT* intended for real cirrus devices. This requires > - the modesetting userspace X.org driver. > - > - Cirrus is obsolete, the hardware was designed in the 90ies > - and can't keep up with todays needs. More background: > - https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ > - > - Better alternatives are: > - - stdvga (DRM_BOCHS, qemu -vga std, default in qemu 2.2+) > - - qxl (DRM_QXL, qemu -vga qxl, works best with spice) > - - virtio (DRM_VIRTIO_GPU), qemu -vga virtio) > diff --git a/drivers/gpu/drm/cirrus/Makefile b/drivers/gpu/drm/cirrus/Makefile > deleted file mode 100644 > index 0c1ed3f99725..000000000000 > --- a/drivers/gpu/drm/cirrus/Makefile > +++ /dev/null > @@ -1,2 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0-only > -obj-$(CONFIG_DRM_CIRRUS_QEMU) += cirrus.o > diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig > index 4160e74e4751..2b6414f0fa75 100644 > --- a/drivers/gpu/drm/tiny/Kconfig > +++ b/drivers/gpu/drm/tiny/Kconfig > @@ -1,5 +1,24 @@ > # SPDX-License-Identifier: GPL-2.0-only > > +config DRM_CIRRUS_QEMU > + tristate "Cirrus driver for QEMU emulated device" > + depends on DRM && PCI && MMU > + select DRM_KMS_HELPER > + select DRM_GEM_SHMEM_HELPER > + help > + This is a KMS driver for emulated cirrus device in qemu. > + It is *NOT* intended for real cirrus devices. This requires > + the modesetting userspace X.org driver. > + > + Cirrus is obsolete, the hardware was designed in the 90ies > + and can't keep up with todays needs. More background: > + https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ > + > + Better alternatives are: > + - stdvga (DRM_BOCHS, qemu -vga std, default in qemu 2.2+) > + - qxl (DRM_QXL, qemu -vga qxl, works best with spice) > + - virtio (DRM_VIRTIO_GPU), qemu -vga virtio) > + > config DRM_GM12U320 > tristate "GM12U320 driver for USB projectors" > depends on DRM && USB > diff --git a/drivers/gpu/drm/tiny/Makefile b/drivers/gpu/drm/tiny/Makefile > index c96ceee71453..6ae4e9e5a35f 100644 > --- a/drivers/gpu/drm/tiny/Makefile > +++ b/drivers/gpu/drm/tiny/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_DRM_CIRRUS_QEMU) += cirrus.o > obj-$(CONFIG_DRM_GM12U320) += gm12u320.o > obj-$(CONFIG_TINYDRM_HX8357D) += hx8357d.o > obj-$(CONFIG_TINYDRM_ILI9225) += ili9225.o > diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c > similarity index 100% > rename from drivers/gpu/drm/cirrus/cirrus.c > rename to drivers/gpu/drm/tiny/cirrus.c > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel