From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A89C83008 for ; Tue, 28 Apr 2020 13:06:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD270206D6 for ; Tue, 28 Apr 2020 13:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IT2kqtnh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD270206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93A2B89E06; Tue, 28 Apr 2020 13:06:34 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id E472D897D7 for ; Tue, 28 Apr 2020 13:06:32 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id y24so2779337wma.4 for ; Tue, 28 Apr 2020 06:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GvCnubnVKmIVoSEYhFz+uK0U01NbdfHDTxNrt/s7zTM=; b=IT2kqtnhvzGdmdz5+97kbMxrBEF3M23KSFOw84igRCF3reesSLpKPRVaP0rO5e+YpD 7giH92phiSHnd0MIfLWlZQTTN718o9kErQ+uFjDvIjJ6BzXHWxsIr4sdHfHc1ctTNmSE P0ivJas4Ds9oQCPzSsU0874DgbD0BsJwV4V7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GvCnubnVKmIVoSEYhFz+uK0U01NbdfHDTxNrt/s7zTM=; b=sU2Rbp2rs/yhR6qNESrnk1XpnFhGWBA1a0KqC0RN3v2yOs7HwW2qnmQuz3LosTk6+0 z6EzKG7e7fVohpIgyc3NgQxdHTAl4el0wvizP//F6TQYJq4YJaKJ8U2SoFyC+BmoY7Jd UrOyJ+byQlrVtUVCCii6ymcXtf6LGiAvRytNHMYm77ETPVDrQuBG2QXqSNaVfnj88bje MXdMOeRQAgyp7SgiihaeXAzgsGTDviXRYXP+I5Z30TmiKYyH+72MmcpDKW56CnFvoygY +B+PR1WPsPQCV9sP+97If20bsS1KpvPkmFhTBejEgba8MD2YdsHnUSC9q71T3BKZjxTE G5rg== X-Gm-Message-State: AGi0Pua21N8o247GfPiXejR/vZNX8ac5Ef5Xu4bNHVDFqG+1f/4iOAcs YUgOloOqjyBkiyiIGeBGKHemxw== X-Google-Smtp-Source: APiQypJ9VrKGxZIPeEzgKtRg4Q1iG6C8ah9yulx2Kv2AdGFCAMOR++Kr7Z0rzxXagK+HWbpFMRQfpg== X-Received: by 2002:a1c:a58b:: with SMTP id o133mr4445404wme.5.1588079191545; Tue, 28 Apr 2020 06:06:31 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h5sm26169744wrp.97.2020.04.28.06.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 06:06:30 -0700 (PDT) Date: Tue, 28 Apr 2020 15:06:28 +0200 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH 01/59] drm: Add devm_drm_dev_alloc macro Message-ID: <20200428130628.GH3456981@phenom.ffwll.local> References: <20200415074034.175360-1-daniel.vetter@ffwll.ch> <20200415074034.175360-2-daniel.vetter@ffwll.ch> <4d5229c2-acb4-b76f-13c7-88a5f3de4760@suse.de> <20200421203245.GA25673@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200421203245.GA25673@ravnborg.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Paul Kocialkowski , Laurent Pinchart , Thomas Zimmermann , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 21, 2020 at 10:32:45PM +0200, Sam Ravnborg wrote: > Hi > > > > Hm, I see the point of this (and the dev_field below, although I'd go > > > with dev_member there for some consistency with other macros using > > > offset_of or container_of), but I'm not sure about the dev_ prefix. > > > Drivers use that sometimes for the struct device *, and usage for > > > struct drm_device * is also very inconsistent. I've seen ddev, drm, > > > dev and base (that one only for embedded structs ofc). So not sure > > > which prefix to pick, aside from dev_ seems the most confusing. Got > > > ideas? > > > > We have pdev for the PCI device, dev for the abstract device, and things > > like mdev for struct mga_device in mgag200. So I'd go with ddev. I don't > > like drm, because it could be anything in DRM. I guess struct drm_driver > > is more 'drm' than struct drm_device. > > > > But all of this is bikeshedding. It's probably best to keep the patch > > as-is, and maybe rename variables later if we ever find consent on the > > naming. > > bikeshedding - I know. > But reading code is is quite natural for me that drm equals the central > drm_device data structure. Maybe thats because this was is in the code > I started looking at. > > So as an example: > > drm_err(drm, "bla bla\n"); > > This parses nicely and is easy to type and get right. > And matches nicely that drm_device => drm. > But bikeshedding - I will go to bed... > (Whatever is the conclusion we should not hold back the patch in > questions). Ok, since we can't agree on dev vs ddev vs drm vs something else I just left it as-is. We can always repaint this later on. Thanks everyone for comments and review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel