From: Dan Carpenter <dan.carpenter@oracle.com>
To: Oliver Graute <oliver.graute@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
gregkh@linuxfoundation.org,
Oliver Graute <oliver.graute@kococonnector.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion
Date: Tue, 28 Apr 2020 21:58:54 +0300 [thread overview]
Message-ID: <20200428185854.GK2014@kadam> (raw)
In-Reply-To: <20200427082939.GB18436@portage>
On Mon, Apr 27, 2020 at 10:29:39AM +0200, Oliver Graute wrote:
> On 09/04/20, Dan Carpenter wrote:
> > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> > > From: Oliver Graute <oliver.graute@kococonnector.com>
> > >
> > > Enable inversion mode
> >
> > What the heck is an inversion mode and why would you want it?
>
>
> Should I name it:
>
> Enable MIPI_DCS_ENTER_INVERT_MODE
>
What I'm saying is the changelog should explain why would want to apply
the patch. What does the inversion mode do? Is it inverting the color
or flipping something upside down?
Probably if I had a background in graphics I would know what "Enable
inversion mode" means... But three words is not a proper and complete
commit message normally.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-04-28 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 9:24 [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion Oliver Graute
2020-04-09 10:14 ` Dan Carpenter
2020-04-27 8:31 ` Oliver Graute
2020-04-09 10:15 ` Dan Carpenter
2020-04-27 8:29 ` Oliver Graute
2020-04-28 18:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428185854.GK2014@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.graute@gmail.com \
--cc=oliver.graute@kococonnector.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).