From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument
Date: Thu, 30 Apr 2020 17:52:50 +0300 [thread overview]
Message-ID: <20200430145250.GX6112@intel.com> (raw)
In-Reply-To: <CACvgo51i8_Xyp4=RVfcft9FsasMh4G9ze1jrc0Mg8ObOZCHn5g@mail.gmail.com>
On Thu, Apr 30, 2020 at 02:47:00PM +0100, Emil Velikov wrote:
> Hi Hans,
>
> On Fri, 21 Feb 2020 at 17:33, Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching
> > a video= argument over calculating our own timings for the user specified
> > mode using CVT or GTF.
> >
> > But userspace code which is auto-configuring the mode may want to know that
> > the user has specified that mode on the kernel commandline so that it can
> > pick that mode over the mode which is marked as DRM_MODE_TYPE_PREFERRED.
> >
> > This commit sets the DRM_MODE_TYPE_USERDEF flag on the matching mode, just
> > as we would do on the user-specified mode when no matching probed mode is
> > found.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> I was skimming around wrt Ville's compact drm_display_mode series and
> noticed that this never landed.
>
> The commit brings extra consistency when dealing with user defined
> modes, and is:
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
>
> Ville this may trivially conflict with your work. I suspect you can do
> the honours, and apply on top of your series?
> That is if you agree with the patch.
Quick glance at the original thread says maybe there were still some
userspace issues unresolved? Not sure.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-30 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 17:33 [PATCH resend 0/1] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes Hans de Goede
2020-02-21 17:33 ` [PATCH resend] drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument Hans de Goede
2020-04-30 13:47 ` Emil Velikov
2020-04-30 14:52 ` Ville Syrjälä [this message]
2020-04-30 14:55 ` Hans de Goede
2020-05-14 9:53 ` Emil Velikov
2020-05-14 14:35 ` Hans de Goede
2020-05-17 20:59 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430145250.GX6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).