From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D41C47247 for ; Tue, 5 May 2020 16:31:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AD4020735 for ; Tue, 5 May 2020 16:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AD4020735 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D53D189F07; Tue, 5 May 2020 16:31:04 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 635BA89F07 for ; Tue, 5 May 2020 16:31:04 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 5CC90804B9; Tue, 5 May 2020 18:31:01 +0200 (CEST) Date: Tue, 5 May 2020 18:30:59 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 0/5] drm/mgag200: Embed DRM device in struct mga_device Message-ID: <20200505163059.GA5082@ravnborg.org> References: <20200505095649.25814-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200505095649.25814-1-tzimmermann@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=rlxZBRk7VnPCS96vd50A:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cogarre@gmail.com, dri-devel@lists.freedesktop.org, kraxel@redhat.com, airlied@redhat.com, emil.velikov@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Tue, May 05, 2020 at 11:56:44AM +0200, Thomas Zimmermann wrote: > After receiving reviews on the conversion of mgag200 to atomic mode > setting, I thought it would make sense to embed the DRM device in > struct mga_device first. Several comments in the atomic-conversion > reviews refer to that. I would have preferred that this was on top of at least some of the existing patches, as they are tested by at least one other person and reveiwed too (at least some of them, but maybe only by me). Anyway, now you did it like this and Daniel has reviewed so let's move on from here. Sam > > Patches 1 to 3 do some cleanups and preparation work. Patch 4 changes > the the init functions to allocate struct mga_device before struct > drm_device. Patch 5 does the conversion. > > I did not switch over struct mga_device to the new managed release > code. I found that this justifies another round of cleanup patches, > which I did not want to put into this patchset. > > The patches were tested on mgag200 hardware. > > Thomas Zimmermann (5): > drm/mgag200: Convert struct drm_device to struct mga_device with macro > drm/mgag200: Integrate init function into load function > drm/mgag200: Remove several references to struct mga_device.dev > drm/mgag200: Init and finalize devices in mgag200_device_{init,fini}() > drm/mgag200: Embed DRM device instance in struct mga_device > > drivers/gpu/drm/mgag200/mgag200_cursor.c | 10 +- > drivers/gpu/drm/mgag200/mgag200_drv.c | 29 +++--- > drivers/gpu/drm/mgag200/mgag200_drv.h | 8 +- > drivers/gpu/drm/mgag200/mgag200_i2c.c | 10 +- > drivers/gpu/drm/mgag200/mgag200_main.c | 114 +++++++++++------------ > drivers/gpu/drm/mgag200/mgag200_mode.c | 35 +++---- > drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +- > 7 files changed, 101 insertions(+), 109 deletions(-) > > -- > 2.26.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel