From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A619C47257 for ; Wed, 6 May 2020 15:56:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF453208DB for ; Wed, 6 May 2020 15:56:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JSCJRr1Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF453208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5945C891B1; Wed, 6 May 2020 15:56:56 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFD22891B1 for ; Wed, 6 May 2020 15:56:54 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E30A9542; Wed, 6 May 2020 17:56:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1588780613; bh=JqP+SOCphmyvR7LY5kOsdyerYHIGqof5vTW6QMlbE0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JSCJRr1YjHYhNJEGPipbcitzN44oikeZK4tjqwRcMKFUE4bUrDOMma8NIzvzBgk0S 5gJAR9gGYZ7ytOiUKewbJSais47zFkOxx0YnkZW8MXmf+cT8rRSO/PxqG9mwqEQD+v AjYuBY3gGFlLCdse5mLMf21yRvmsRIJ/EgkXX6ME= Date: Wed, 6 May 2020 18:56:47 +0300 From: Laurent Pinchart To: Doug Anderson Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity Message-ID: <20200506155647.GD15206@pendragon.ideasonboard.com> References: <20200504213624.1.Ibc8eeddcee94984a608d6900b46f9ffde4045da4@changeid> <20200505082436.GD9658@pendragon.ideasonboard.com> <20200505210609.GA6094@pendragon.ideasonboard.com> <20200505211401.GC6094@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Jernej Skrabec , Neil Armstrong , David Airlie , linux-arm-msm , Jonas Karlman , LKML , dri-devel , Andrzej Hajda , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Doug, On Tue, May 05, 2020 at 05:18:48PM -0700, Doug Anderson wrote: > On Tue, May 5, 2020 at 2:24 PM Doug Anderson wrote: > > On Tue, May 5, 2020 at 2:14 PM Laurent Pinchart wrote: > > > > > > > I'll add this documentation into the comments of the yaml, but I'm not > > > > going to try to implement enforcement at the yaml level. > > > > > > Why not ? :-) > > > > Because trying to describe anything in the yaml bindings that doesn't > > fit in the exact pattern of things that the yaml bindings are designed > > to check is like constructing the empire state building with only > > toothpicks. > > > > If you want to suggest some syntax that would actually make this > > doable without blowing out the yaml bindings then I'm happy to add it. > > Me being naive would assume that we'd need to do an exhaustive list of > > the OK combinations. That would be fine for the 1-land and 2-lane > > cases, but for 4 lanes that means adding 256 entries to the bindings. > > > > I think the correct way to do this would require adding code in the > > project but that's > > really only done for generic subsystem-level concepts and not for a > > single driver. > > OK. Looked at your review of the .yaml and the "uniqueItems" is > probably the bit I didn't think of. With that I can limit this but > it's still a little awkward. I still haven't figured out how to force > data-lanes and lane-polarities to have the same number of items, too. > I'll add this as an add-on patch to my v2 and folks can decide if they > like it or hate it. Thanks for looking into it. Looks good to me. Regarding the same number of items I would assume it should be possible, I would be surprised if the schemas allowed a different number of items for clocks and clock-names for instance, but maybe that's not implemented yet. In any case, no big deal. > # See ../../media/video-interface.txt for details. > data-lanes: > oneOf: > - minItems: 1 > maxItems: 1 > uniqueItems: true > items: > enum: > - 0 > - 1 > description: > If you have 1 logical lane it can go to either physical > port 0 or port 1. Port 0 is suggested. > > - minItems: 2 > maxItems: 2 > uniqueItems: true > items: > enum: > - 0 > - 1 > description: > If you have 2 logical lanes they can be reordered on > physical ports 0 and 1. > > - minItems: 4 > maxItems: 4 > uniqueItems: true > items: > enum: > - 0 > - 1 > - 2 > - 3 > description: > If you have 4 logical lanes they can be reordered on > in any way. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel