From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D307C35280 for ; Fri, 8 May 2020 02:20:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A222070B for ; Fri, 8 May 2020 02:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06A222070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E16B6E127; Fri, 8 May 2020 02:20:41 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A3E56E126; Fri, 8 May 2020 02:20:39 +0000 (UTC) IronPort-SDR: sLYjGUbjHKnAWQovlf4Mu575v9pdiJWm7A+4AcHtVTe+o1LpK30j+GeDNwgfXxUyDWZ5oTF/8Q Kzt8kJ88Wp/Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 19:20:39 -0700 IronPort-SDR: LDkFWHHBbP2bfYOq5UuE96zwayAebjocsUKx5BCyycJvVmMv5cB87eIE0oLfZMgPI6TRfYCva8 SVceKsZIB1Dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="249487077" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 07 May 2020 19:20:37 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1jWscu-000Bvx-MP; Fri, 08 May 2020 10:20:36 +0800 Date: Fri, 8 May 2020 10:20:09 +0800 From: kbuild test robot To: Gwan-gyeong Mun , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v11 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR Message-ID: <202005081038.ctmtcNFX%lkp@intel.com> References: <20200507132706.2058969-15-gwan-gyeong.mun@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507132706.2058969-15-gwan-gyeong.mun@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kbuild-all@lists.01.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Gwan-gyeong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20200507] [cannot apply to tegra-drm/drm/tegra/for-next linus/master v5.7-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Gwan-gyeong-Mun/In-order-to-readout-DP-SDPs-refactors-the-handling-of-DP-SDPs/20200508-034404 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot New smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:727 intel_psr_compute_config() warn: inconsistent indenting Old smatch warnings: drivers/gpu/drm/i915/display/intel_psr.c:1564 intel_psr_short_pulse() error: uninitialized symbol 'error_status'. drivers/gpu/drm/i915/display/intel_psr.c:1569 intel_psr_short_pulse() error: uninitialized symbol 'error_status'. vim +727 drivers/gpu/drm/i915/display/intel_psr.c 711 712 void intel_psr_compute_config(struct intel_dp *intel_dp, 713 struct intel_crtc_state *crtc_state) 714 { 715 struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); 716 struct drm_i915_private *dev_priv = dp_to_i915(intel_dp); 717 const struct drm_display_mode *adjusted_mode = 718 &crtc_state->hw.adjusted_mode; 719 int psr_setup_time; 720 721 if (!CAN_PSR(dev_priv)) 722 return; 723 724 if (intel_dp != dev_priv->psr.dp) 725 return; 726 > 727 if (!psr_global_enabled(dev_priv)) 728 return; 729 /* 730 * HSW spec explicitly says PSR is tied to port A. 731 * BDW+ platforms have a instance of PSR registers per transcoder but 732 * for now it only supports one instance of PSR, so lets keep it 733 * hardcoded to PORT_A 734 */ 735 if (dig_port->base.port != PORT_A) { 736 drm_dbg_kms(&dev_priv->drm, 737 "PSR condition failed: Port not supported\n"); 738 return; 739 } 740 741 if (dev_priv->psr.sink_not_reliable) { 742 drm_dbg_kms(&dev_priv->drm, 743 "PSR sink implementation is not reliable\n"); 744 return; 745 } 746 747 if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) { 748 drm_dbg_kms(&dev_priv->drm, 749 "PSR condition failed: Interlaced mode enabled\n"); 750 return; 751 } 752 753 psr_setup_time = drm_dp_psr_setup_time(intel_dp->psr_dpcd); 754 if (psr_setup_time < 0) { 755 drm_dbg_kms(&dev_priv->drm, 756 "PSR condition failed: Invalid PSR setup time (0x%02x)\n", 757 intel_dp->psr_dpcd[1]); 758 return; 759 } 760 761 if (intel_usecs_to_scanlines(adjusted_mode, psr_setup_time) > 762 adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vdisplay - 1) { 763 drm_dbg_kms(&dev_priv->drm, 764 "PSR condition failed: PSR setup time (%d us) too long\n", 765 psr_setup_time); 766 return; 767 } 768 769 crtc_state->has_psr = true; 770 crtc_state->has_psr2 = intel_psr2_config_valid(intel_dp, crtc_state); 771 crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_VSC); 772 } 773 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel