From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE552C47255 for ; Mon, 11 May 2020 10:12:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B49B720720 for ; Mon, 11 May 2020 10:12:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="b+tSFMrv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B49B720720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B26ED89AF3; Mon, 11 May 2020 10:12:08 +0000 (UTC) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1924D89AF3 for ; Mon, 11 May 2020 10:12:07 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id g12so18504293wmh.3 for ; Mon, 11 May 2020 03:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=AxDN71QWVlIvPR/Qe9BjED7lK/KCTSrcSC7GeFvMB4Y=; b=b+tSFMrvsOVBFnenMDfROizokqqsnSkXcglzgocb+51zy42IXbNcvm5CHNupiOZMBs ANqitFhidqbalpsVfp+bA/q0JND5ePnK4K7dgxr1Y+0WOZLuIknw/CLde/AY7WU+iUoV fDLkN/x1hi73cW3Lol0SnEsnc+wQwS//RVi7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=AxDN71QWVlIvPR/Qe9BjED7lK/KCTSrcSC7GeFvMB4Y=; b=fUxvS/zTYWhjceWDC2E8LOhgqogKuSboCbFz/KYkuE054oSCv34HmSwk+0cd+zHDES flUgCEDOBCMV6OrVprcn5yXWujcQGoIw1oRhfwMCFmpSGwNNvGY1+kkTESTV2080vS1I f7w8Gbsg3dBCOZj6xmNJ50/dvF1Ygrv0xNt1J1zVEdBa331QoY8kChbcREkxbfVqEQhZ LTgE97fLIuQzhcaJb8MeH4BFFnyH+cn9RGtA1nr2kkHfkVXBuy7a0RBZves3CVlutmcX LLPX1AhEFXkF7MqeucgMQgBuU5yHudRQmlznfkuIjVg0g61IYNOBS4BJ64j4vjMgCziG 0MKg== X-Gm-Message-State: AGi0PuYCK/0RM4UHmBvf1FbgMzcwroyU1mvtk41JCBwqZ3JVpPVnRoFN dbJP5wef6idfkrsth5CYbnmZcg== X-Google-Smtp-Source: APiQypJduS5g8MSJy/JNzf+Alo7zIfVFjEdcgIp2nM0k6p91EvBmHQ+tR8aq272pVf8oIkv+vmiJPw== X-Received: by 2002:a05:600c:230e:: with SMTP id 14mr2914697wmo.45.1589191925721; Mon, 11 May 2020 03:12:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a10sm18015507wrp.0.2020.05.11.03.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 03:12:05 -0700 (PDT) Date: Mon, 11 May 2020 12:12:02 +0200 From: Daniel Vetter To: Chris Wilson Subject: Re: [PATCH 2/3] dma-fence: use default wait function for mock fences Message-ID: <20200511101202.GB206103@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , LKML , Intel Graphics Development , DRI Development , linaro-mm-sig@lists.linaro.org, Daniel Vetter , linux-media@vger.kernel.org References: <20200511091142.208787-1-daniel.vetter@ffwll.ch> <20200511091142.208787-2-daniel.vetter@ffwll.ch> <158919006380.1729.6928823811672806738@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158919006380.1729.6928823811672806738@build.alporthouse.com> X-Operating-System: Linux phenom 5.6.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , LKML , DRI Development , linaro-mm-sig@lists.linaro.org, Daniel Vetter , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 11, 2020 at 10:41:03AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2020-05-11 10:11:41) > > No need to micro-optmize when we're waiting in a mocked object ... > > It's setting up the expected return values for the test. Drat, I suspect something like that but didn't spot it. Kinda wondering whether we should maybe lift the -ETIME special case to the generic version. But that's not really a safe thing to do there, drivers might actually use it for funny stuff. Anyway motivation is that I'm pondering some extensions of dma_fence_wait and removing as many of the ->wait hooks as possible would have helped. But there's some nastier stuff like the legacy nouvea and radeon ones. -Daniel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel