* [PATCH] drm/i915: Remove duplicate inline specifier on write_pte
@ 2020-05-13 18:23 Nathan Chancellor
2020-05-13 18:26 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2020-05-13 18:23 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: kbuild test robot, Mika Kuoppala, intel-gfx, linux-kernel,
dri-devel, Chris Wilson, clang-built-linux, Nathan Chancellor
When building with clang:
drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate
'inline' declaration specifier [-Wduplicate-decl-specifier]
declaration specifier [-Wduplicate-decl-specifier]
static __always_inline inline void
^
include/linux/compiler_types.h:138:16: note: expanded from macro
'inline'
#define inline inline __gnu_inline __inline_maybe_unused notrace
^
1 warning generated.
__always_inline is defined as 'inline __attribute__((__always_inline))'
so we do not need to specify it twice.
Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory")
Link: https://github.com/ClangBuiltLinux/linux/issues/1024
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
index 2dc88e76ebec..699125928272 100644
--- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
@@ -389,7 +389,7 @@ static int gen8_ppgtt_alloc(struct i915_address_space *vm,
return err;
}
-static __always_inline inline void
+static __always_inline void
write_pte(gen8_pte_t *pte, const gen8_pte_t val)
{
/* Magic delays? Or can we refine these to flush all in one pass? */
base-commit: e098d7762d602be640c53565ceca342f81e55ad2
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Remove duplicate inline specifier on write_pte
2020-05-13 18:23 [PATCH] drm/i915: Remove duplicate inline specifier on write_pte Nathan Chancellor
@ 2020-05-13 18:26 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2020-05-13 18:26 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi
Cc: kbuild test robot, Mika Kuoppala, intel-gfx, linux-kernel,
dri-devel, clang-built-linux, Nathan Chancellor
Quoting Nathan Chancellor (2020-05-13 19:23:40)
> When building with clang:
>
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate
> 'inline' declaration specifier [-Wduplicate-decl-specifier]
> declaration specifier [-Wduplicate-decl-specifier]
> static __always_inline inline void
> ^
> include/linux/compiler_types.h:138:16: note: expanded from macro
> 'inline'
> #define inline inline __gnu_inline __inline_maybe_unused notrace
> ^
> 1 warning generated.
>
> __always_inline is defined as 'inline __attribute__((__always_inline))'
> so we do not need to specify it twice.
>
> Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1024
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
I forgot to ping Mika about this,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 18:23 [PATCH] drm/i915: Remove duplicate inline specifier on write_pte Nathan Chancellor
2020-05-13 18:26 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).