From: Xin Ji <xji@analogixsemi.com>
To: Rob Herring <robh@kernel.org>
Cc: devel@driverdev.osuosl.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Pi-Hsun Shih <pihsun@chromium.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v10 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Date: Fri, 15 May 2020 10:45:52 +0800 [thread overview]
Message-ID: <20200515024552.GA11753@xin-VirtualBox> (raw)
In-Reply-To: <20200514145432.GA6091@bogus>
Hi Rob Herring,
Thanks for your comments.
On Thu, May 14, 2020 at 09:54:32AM -0500, Rob Herring wrote:
> On Wed, May 06, 2020 at 03:04:20PM +0800, Xin Ji wrote:
> > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> > for portable device. It converts MIPI to DisplayPort 1.3 4K.
> >
> > You can add support to your board with binding.
>
> We have an example in the binding, no reason to also put in the commit
> msg.
OK
>
> >
> > Example:
> > anx7625_bridge: encoder@58 {
> > compatible = "analogix,anx7625";
> > reg = <0x58>;
> > status = "okay";
> > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> >
> > ports {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > mipi2dp_bridge_in: port@0 {
> > reg = <0>;
> > anx7625_in: endpoint {
> > remote-endpoint = <&mipi_dsi>;
> > };
> > };
> >
> > mipi2dp_bridge_out: port@1 {
> > reg = <1>;
> > anx7625_out: endpoint {
> > remote-endpoint = <&panel_in>;
> > };
> > };
> > };
> > };
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > .../bindings/display/bridge/analogix,anx7625.yaml | 98 ++++++++++++++++++++++
> > 1 file changed, 98 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > new file mode 100644
> > index 0000000..6e54176
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2019 Analogix Semiconductor, Inc.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> > +
> > +maintainers:
> > + - Xin Ji <xji@analogixsemi.com>
> > +
> > +description: |
> > + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > + designed for portable devices.
> > +
> > +properties:
> > + "#address-cells": true
> > + "#size-cells": true
>
> These don't belong here.
OK
>
> > +
> > + compatible:
> > + items:
> > + - const: analogix,anx7625
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + description: used for interrupt pin B8.
> > + maxItems: 1
> > +
> > + enable-gpios:
> > + description: used for power on chip control, POWER_EN pin D2.
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description: used for reset chip control, RESET_N pin B7.
> > + maxItems: 1
> > +
> > + ports:
> > + type: object
> > +
> > + properties:
> > + port@0:
> > + type: object
> > + description:
> > + Video port for MIPI DSI input.
> > +
> > + port@1:
> > + type: object
> > + description:
> > + Video port for panel or connector.
> > +
> > + required:
> > + - port@0
> > + - port@1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + anx7625_bridge: encoder@58 {
>
> Drop any unused labels.
OK
>
> > + compatible = "analogix,anx7625";
> > + reg = <0x58>;
> > + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mipi2dp_bridge_in: port@0 {
> > + reg = <0>;
> > + anx7625_in: endpoint {
> > + remote-endpoint = <&mipi_dsi>;
> > + };
> > + };
> > +
> > + mipi2dp_bridge_out: port@1 {
> > + reg = <1>;
> > + anx7625_out: endpoint {
> > + remote-endpoint = <&panel_in>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.7.4
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-15 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 7:03 [PATCH v10 0/2] Add initial support for slimport anx7625 Xin Ji
2020-05-06 7:04 ` [PATCH v10 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Xin Ji
2020-05-14 14:54 ` Rob Herring
2020-05-15 2:45 ` Xin Ji [this message]
2020-05-06 7:05 ` [PATCH v10 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515024552.GA11753@xin-VirtualBox \
--to=xji@analogixsemi.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=pihsun@chromium.org \
--cc=robh@kernel.org \
--cc=span@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).