From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe
Date: Wed, 27 May 2020 16:43:34 -0400 [thread overview]
Message-ID: <20200527204334.GA15485@kevin> (raw)
In-Reply-To: <20200527200544.7849-1-krzk@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1745 bytes --]
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error. Also there is no need to print regulator errors
> twice.
>
> In case of multiple probe tries this would pollute the dmesg.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Steven Price <steven.price@arm.com>
>
> ---
>
> Changes since v2:
> 1. Rebase
> 2. Add Steven's review
>
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init()
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 8136babd3ba9..b172087eee6a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
> pfdev->comp->num_supplies,
> pfdev->regulators);
> if (ret < 0) {
> - dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "failed to get regulators: %d\n",
> + ret);
> return ret;
> }
>
> @@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
> }
>
> err = panfrost_regulator_init(pfdev);
> - if (err) {
> - dev_err(pfdev->dev, "regulator init failed %d\n", err);
> + if (err)
> goto err_out0;
> - }
>
> err = panfrost_reset_init(pfdev);
> if (err) {
> --
> 2.17.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-28 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:05 [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
2020-05-27 20:43 ` Alyssa Rosenzweig [this message]
2020-06-17 14:15 ` Krzysztof Kozlowski
2020-06-17 14:35 ` Steven Price
2020-06-17 19:57 ` Rob Herring
2020-06-18 9:28 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527204334.GA15485@kevin \
--to=alyssa.rosenzweig@collabora.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).