From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E127C433E1 for ; Thu, 28 May 2020 01:48:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40DC1204EA for ; Thu, 28 May 2020 01:48:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sdVgaQBI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DC1204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D7F36E13B; Thu, 28 May 2020 01:48:56 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E7FD6E13B for ; Thu, 28 May 2020 01:48:55 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C59812A3; Thu, 28 May 2020 03:48:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1590630532; bh=U4kq/jSbwNGuKVGeEHlzWvc3R7NEee14LdRS0610D+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sdVgaQBICro/JkQEixC7dLVChef2a3hJuZPkokvJZsnUfJam/kJl/yhEOuU6HqF5K sACsXGtsSlhkcr+GTq6mlcw04pdgZ2qXhQD+yzwVIMRr3ocYdxVDKbzxfGkKOlXm/+ rnuP7/X2gLmOLmoMh33OLsGIZh49vnc5EbSVBmvc= Date: Thu, 28 May 2020 04:48:37 +0300 From: Laurent Pinchart To: Vinod Koul Subject: Re: [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611 Message-ID: <20200528014837.GD4670@pendragon.ideasonboard.com> References: <20200513100533.42996-1-vkoul@kernel.org> <20200513100533.42996-3-vkoul@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200513100533.42996-3-vkoul@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , Neil Armstrong , David Airlie , linux-arm-msm@vger.kernel.org, Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , Andrzej Hajda , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Vinod, Thank you for the patch. On Wed, May 13, 2020 at 03:35:32PM +0530, Vinod Koul wrote: > Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports > and I2S port as input and one HDMI port as output > > Signed-off-by: Vinod Koul > --- > .../display/bridge/lontium,lt9611.yaml | 178 ++++++++++++++++++ > 1 file changed, 178 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > new file mode 100644 > index 000000000000..77ee8cc35cd8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > @@ -0,0 +1,178 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lontium LT9611 2 Port MIPI to HDMI Bridge > + > +maintainers: > + - Vinod Koul > + > +description: | > + The LT9611 is a bridge device which converts DSI to HDMI > + > +properties: > + compatible: > + enum: > + - lontium,lt9611 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device. > + > + "#sound-dai-cells": > + const: 1 > + > + interrupts: > + maxItems: 1 > + description: interrupt line for the chip I think you could drop the descriptions for the reg and interrupt properties, they don't add much. > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active high RESET pin. > + > + vdd-supply: > + description: Regulator for 1.8V MIPI phy power. > + > + vcc-supply: > + description: Regulator for 3.3V IO power. > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + additionalProperties: false > + > + description: | > + HDMI port for HDMI output The usual practice is to have the input ports first, followed by the output ports. Is there a reason not to follow that rule ? > + > + properties: > + reg: > + const: 0 > + > + patternProperties: > + endpoint: If you want to use patternProperties, this should be "^endpoint@[0-9]+$": (including the quotes). Same below. > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true How about remote-endpoint: $ref: /schemas/types.yaml#/definitions/phandle and the same below ? You also need a reg property if multiple endpoints are present. > + > + required: > + - reg > + > + port@1: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-1 for MIPI input > + > + properties: > + reg: > + const: 1 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + port@2: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-2 for MIPI input A description of how the two MIPI inputs differ would be useful. In particular, are both mandatory, or is it valid to connect only one of the two ? If using a single input is supported, can it be either, or does it have to be the first one ? When using both inputs, what should be connected to them ? > + > + properties: > + reg: > + const: 2 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply > + - vcc-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c10 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lt9611_codec: hdmi-bridge@3b { Please drop unused labels. > + compatible = "lontium,lt9611"; > + reg = <0x3b>; > + > + reset-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&tlmm 84 IRQ_TYPE_EDGE_FALLING>; > + > + vdd-supply = <<9611_1v8>; > + vcc-supply = <<9611_3v3>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lt9611_out: endpoint { > + remote-endpoint = <&hdmi_con>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lt9611_a: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + lt9611_b: endpoint { > + remote-endpoint = <&dsi1_out>; > + }; > + }; > + }; > + }; > + }; It's customary to end YAML schema files with ... on a separate line. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel