From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D52BC433E1 for ; Thu, 28 May 2020 09:31:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E62E2075F for ; Thu, 28 May 2020 09:31:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E62E2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8793C6E126; Thu, 28 May 2020 09:31:48 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60B816E126 for ; Thu, 28 May 2020 09:31:47 +0000 (UTC) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeEt7-0004v6-F9; Thu, 28 May 2020 11:31:45 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jeEt7-0003cW-4F; Thu, 28 May 2020 11:31:45 +0200 Date: Thu, 28 May 2020 11:31:45 +0200 From: Marco Felsch To: Liu Ying Subject: Re: [PATCH] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable() Message-ID: <20200528093145.kmpzbnesv25k7wvc@pengutronix.de> References: <1589268718-29837-1-git-send-email-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:30:15 up 195 days, 48 min, 196 users, load average: 0.21, 0.18, 0.10 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@pengutronix.de, s.hauer@pengutronix.de, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Liu On 20-05-28 10:58, Liu Ying wrote: > Gentle ping... Please check my "spring cleanup series" [1] which do the split: [1] https://www.spinics.net/lists/arm-kernel/msg789309.html Regards, Marco > On Tue, 2020-05-12 at 15:31 +0800, Liu Ying wrote: > > Both of the two LVDS channels should be disabled for split mode > > in the encoder's ->disable() callback, because they are enabled > > in the encoder's ->enable() callback. > > > > Fixes: 6556f7f82b9c ("drm: imx: Move imx-drm driver out of staging") > > Cc: Philipp Zabel > > Cc: Sascha Hauer > > Cc: Pengutronix Kernel Team > > Cc: NXP Linux Team > > Cc: > > Signed-off-by: Liu Ying > > --- > > drivers/gpu/drm/imx/imx-ldb.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx- > > ldb.c > > index 4da22a9..af4d0d8 100644 > > --- a/drivers/gpu/drm/imx/imx-ldb.c > > +++ b/drivers/gpu/drm/imx/imx-ldb.c > > @@ -303,18 +303,19 @@ static void imx_ldb_encoder_disable(struct > > drm_encoder *encoder) > > { > > struct imx_ldb_channel *imx_ldb_ch = > > enc_to_imx_ldb_ch(encoder); > > struct imx_ldb *ldb = imx_ldb_ch->ldb; > > + int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; > > int mux, ret; > > > > drm_panel_disable(imx_ldb_ch->panel); > > > > - if (imx_ldb_ch == &ldb->channel[0]) > > + if (imx_ldb_ch == &ldb->channel[0] || dual) > > ldb->ldb_ctrl &= ~LDB_CH0_MODE_EN_MASK; > > - else if (imx_ldb_ch == &ldb->channel[1]) > > + if (imx_ldb_ch == &ldb->channel[1] || dual) > > ldb->ldb_ctrl &= ~LDB_CH1_MODE_EN_MASK; > > > > regmap_write(ldb->regmap, IOMUXC_GPR2, ldb->ldb_ctrl); > > > > - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) { > > + if (dual) { > > clk_disable_unprepare(ldb->clk[0]); > > clk_disable_unprepare(ldb->clk[1]); > > } > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel